Rely on Exception#message rather than overloading with attr_reader#11
Open
josh-lauer wants to merge 1 commit intowaits:masterfrom
Open
Rely on Exception#message rather than overloading with attr_reader#11josh-lauer wants to merge 1 commit intowaits:masterfrom
josh-lauer wants to merge 1 commit intowaits:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby implements a method, Exception#message, which returns the result of calling #to_s on the exception object: https://ruby-doc.org/core-2.2.0/Exception.html#method-i-message
In the ApiError class, the constructor in some cases sets @message to be an HTTP::Response object. Removing the message attr_reader allows Exception#message to be called instead, which in turn calls #to_s. This change ensures that #message always returns a string, rather than sometimes unexpectedly returning an HTTP::Response object.