Use system htslib; a couple minor tweaks#64
Open
julianhess wants to merge 7 commits intowalaj:masterfrom
Open
Conversation
No need to enumerate the whole CIGAR string; we need only to look at the first and lass CIGAR operators, since clips cannot occur anywhere else in the read.
Contributor
Author
|
BTW, it looks like we have to update the test suite VM to include an installation of htslib. |
Owner
|
I think this makes sense, thanks for the updates. I'd like to see it pass the test suite first. Can you add the following to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The htslib submodule was getting stale; I think it's better if we use whatever system htslib is already included.
Also implemented a more efficient way of getting the number of softclipped bases, and provided a function for getting the current region index.