Module does not detect if machine is already joined

[dekimsey]

I'm trying to use this module to set-up Centrify in a previously mixed environments. On machines that already have centrify registered, the module fails.

How can I configure this such that provisioning works correctly (does a selfserve join), but then does not attempt to do it on machines that are already successfully joined.

notice /Stage[main]/Centrify::Adjoin::Selfserve/Exec[adjoin_with_selfserve]/returns Error: this computer is already joined to the domain.
notice /Stage[main]/Centrify::Adjoin::Selfserve/Exec[adjoin_with_selfserve]/returns Use adleave first.
err Puppet adjoin -w -V --selfserve 'EXAMPLE.COM' returned 11 instead of one of [0]
err /Stage[main]/Centrify::Adjoin::Selfserve/Exec[adjoin_with_selfserve]/returns change from notrun to 0 failed: adjoin -w -V --selfserve 'EXAMPLE.COM' returned 11 instead of one of [0]

Perhaps checking adinfo first?

$ adinfo
Local host name:   test-foo-01
Joined to domain:  example.com
Joined as:         test-foo-01.example.com
Pre-win2K name:    test-foo-01
Current DC:        dev-ad-01.example.com
Preferred site:    Site-Examplecom
Zone:              Auto Zone
CentrifyDC mode:   connected
Licensed Features: Disabled

Parameters:

  centrify:
    domain: EXAMPLE.COM
    join_type: selfserve
    use_express_license: true

[dekimsey]

Ah. I found the issue, the adinfo test already in the module is case-sensitive. To my knowledge it shouldn't be.

[onzyone]

Feel free to put a downcase() and create a PR

[dekimsey]

I wasn't sure how you might want to update the tests, so I did not change them.

[dekimsey]

I don't see any errors in the CI logs, not sure what is generating the errors.