Open
Conversation
walkerlj0
reviewed
Mar 2, 2021
| @@ -1,4 +1,4 @@ | |||
| package test.java.com.saucelabs.advancedselenium; | |||
| package com.saucelabs.advancedselenium; | |||
Owner
There was a problem hiding this comment.
With the way the tests is set up, based on this: https://github.com/saucelabs-training/advanced-selenium/tree/new_base repo, the tests won't work unless they are named as they were before
walkerlj0
reviewed
Mar 2, 2021
| @@ -1,70 +1,72 @@ | |||
| package test.java.com.saucelabs.advancedselenium; | |||
| package com.saucelabs.advancedselenium; | |||
Owner
There was a problem hiding this comment.
With the way the tests is set up, based on this: https://github.com/saucelabs-training/advanced-selenium/tree/new_base repo, the tests won't work unless they are named as they were before
| @Override | ||
| protected void testSuccessful(ExtensionContext context) { | ||
| session.stop(true); | ||
| public void testSuccessful(ExtensionContext context) { |
Owner
There was a problem hiding this comment.
I am gettting a log of 'Test Passed!' after test, but session info isn't being passed to Sauce Labs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test.java.(IntelliJ might have the wrong folder set as Test Source)MyTestWatcherinstead ofSauceTestWatcherbecause it has to handle both local & sauce use casesRegisterExtensioneven though the instance isn't actually used; code complains withExtendWithprobably because we are annotating the outer class and it doesn't like that