fix(attribute): horizontal -ml-7 value pull, drawer/dialog and page-header edge paddings#235
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The pt-4/pb-4 added in #230 kept the focus ring from clipping but left the content too tight against the viewport edges - use 8px on both the top edge and the footer-side bottom edge. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…[update-screenshots] The hit-target pull for InlineEdit and AttributeActionsTarget guests was vertical-only, so horizontal values hosted by either guest sat 6-7px to the right of plain values. Apply the pull in both orientations and add Mixed stories (plain + Actions + InlineEdit stacked) with visual e2e coverage of the alignment contract. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
This PR is included in version 0.77.1-rc-fix-horizontal-attr-pull-and-edge-paddings.1 |
ispashkov
force-pushed
the
fix/horizontal-attr-pull-and-edge-paddings
branch
from
July 17, 2026 07:26
9326beb to
8a538d1
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
This PR is included in version 0.77.1-rc-fix-horizontal-attr-pull-and-edge-paddings.2 |
…-screenshots] Select/DropdownMenu/Popover content carried a static z-50, which zag's popper mirrors into the portal positioner - below any nested drawer or dialog positioner (50 + layer * 20), so an open menu rendered underneath. Zag's dismissable layer stack already sets --layer-index inline on the menu content (menus, selects, and dialogs share one global stack), so the content z-index now derives from it: 50 + layer-index * 20. The ,0 fallback keeps the calc valid while the node is not yet registered. Adds WithNestedSelect stories for Dialog and Drawer plus e2e coverage (elementFromPoint stacking assertions and real option clicks, verified red -> green locally). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…update-screenshots] Drawer and Dialog run on the same Ark/zag dialog machine, so zag's data-has-nested / --nested-layer-count metadata cannot tell a nested Drawer from a nested Dialog - a Drawer opened from a Dialog wrongly pushed the dialog back (and vice versa), and mixed chains inflated the depth counter. A DS-owned DrawerNestingContext now re-counts open descendants per kind (drawer/dialog) transitively, the contents key their pushed-back CSS on data-has-nested-same + --nested-same-kind-count instead of zag's attributes. Adds WithNestedDrawer/WithNestedDialog stories, e2e regression tests for both mixed directions, and hardens the four dropdown stacking probes against the open-animation race (waits for getAnimations() to finish and hit-tests the content center) - the same race that failed e2e shard 1. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
This PR is included in version 0.77.1-rc-fix-horizontal-attr-pull-and-edge-paddings.3 |
Contributor
|
This PR is included in version 0.77.1 |
Contributor
|
This PR is included in version 0.77.1-rc-fix-remote-shell-breadcrumbs.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pb-8→py-8— symmetric 8px vertical padding.drawerContentVariants): thept-4/pb-4edge padding introduced in fix(dialog): stop input focus ring from clipping at body edges #230 becomespt-8/pb-8(footer case).pb-24without a footer is unchanged. Scroll behavior verified: scroll-position borders and the fix(dialog): stop input focus ring from clipping at body edges #230 focus-ring fix still work, with more breathing room at the edges.-ml-7hit-target pull for InlineEdit and AttributeActionsTarget guests now applies in both orientations (was vertical-only), so horizontal values hosted by either guest line up with plain values instead of sitting 6–7px to the right. Theinline-edit-errorcompensation follows the pull.Mixed/Horizontal Mixedstories (plain + Actions + InlineEdit stacked in one column) + visual e2e tests locking the alignment contract.Screenshots
Head commit carries
[update-screenshots]— CI regenerates the affected baselines (Dialog, Drawer, horizontal Attribute, embedded drawers/dialogs in other stories) and creates the two new Mixed baselines, committing them back to this branch.Testing
tsc --noEmitclean.🤖 Generated with Claude Code