refactor: centralize FONT_WEIGHT_MAP in shared typography#142
refactor: centralize FONT_WEIGHT_MAP in shared typography#142RedWilly wants to merge 1 commit intowalterlow:developfrom
Conversation
|
@RedWilly is attempting to deploy a commit to the walterlow's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis change refactors duplicate Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR eliminates duplicate
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["@/shared/typography/font-loader.ts\nFONT_WEIGHT_MAP (source of truth)"]
B["@/shared/typography/fonts.ts\nre-exports FONT_WEIGHT_MAP"]
C["composition-runtime/utils/fonts.ts\nre-exports as FONT_WEIGHT_MAP"]
D["text-layout.ts\n(now imports from shared)"]
E["canvas-item-renderer.ts\n(now imports from shared)"]
F["text-content.tsx\n(imports via feature utils)"]
G["text-section.tsx\n(imports from shared)"]
A --> B
B --> D
B --> E
B --> C
B --> G
C --> F
Reviews (1): Last reviewed commit: "refactor: centralize FONT_WEIGHT_MAP in ..." | Re-trigger Greptile |
Removed duplicated FONT_WEIGHT_MAP definitions and switched composition runtime and export code to use the shared typography source of truth.
Summary by CodeRabbit