챔피언 선택 번호에 따른 이름 배열에 넣기. #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanbok
reviewed
Nov 14, 2019
Owner
wanbok
left a comment
wanbok
left a comment
There was a problem hiding this comment.
if let 등으로 unwrapping하지 않고 고계함수만을 사용해 잘 만셨습니다!
| .filter{ $0["key"] as? String == stringKey } | ||
| .compactMap{ $0["name"] as? String } | ||
| .first | ||
| } |
Owner
There was a problem hiding this comment.
두가지의 고계 함수들을 하나로 합칠 만한 것들이 보입니다.
인지적 복잡도 점수를 더 낮춰가는 방향으로, 연습삼아 변경해보시면 좋을 것 같습니다. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.