Conversation
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 73.9%, saving 393.5 KB.
|
📚 Mintlify Preview Links✨ Added (2 total)📄 Pages (2)
📝 Changed (1 total)⚙️ Other (1)
🤖 Generated automatically when Mintlify deployment succeeds |
🔗 Link Checker ResultsChecked against: https://wb-21fd5541-weave-annotation-q-docs-1869.mintlify.app Summary
Errors per inputErrors in weave/guides/tracking/annotation-queues.mdx
Redirects per inputRedirects in ko/weave.mdx
Redirects in models/track/workspaces.mdx
Redirects in weave/guides/tracking/annotation-queues.mdx
|
chance-wnb
left a comment
chance-wnb
left a comment
There was a problem hiding this comment.
Thanks, overall great work. I shared some initial thoughts from an feature author perspective. Maybe you also want a doc team member to sign off to ensure it is compliant to the doc team's standards.
| In the trace pane header, you can click the Trace ID suffix (for example, "b3ea") to open a panel showing the full trace details for the call. | ||
| </Tip> | ||
|
|
||
| If any annotator has already reviewed an item in the queue, both pane headers of the review interface are decorated with "Has feedback" and "Response submitted" indicators. |
There was a problem hiding this comment.
I feel it is necessary to explain to the user what is going to happen if a queue item has already been annotated?
- Can another user still give feedback(annotate) to the same queue item?
- What is the implications if another user still give feedback? how would it impact the current queue reviewing progress?
There was a problem hiding this comment.
I agree the Docs should clarify this. But, do we know the answers or has this behavior not been sorted out yet?
There was a problem hiding this comment.
Yes the answers are (at the moment):
- Yes.
- Only the first annotation will advance the queue’s overall progress. Later users may still leave feedback on completed items, but their comments will be separate—they will not alter or remove the original feedback, nor will they change the item’s status. We do not track subsequent edits, aside from allowing users to submit feedback on a completed call. This maintains consistency, since users can already freely edit their own feedback from the call details pane even without the annotation feature.
There was a problem hiding this comment.
So question about2: If i navigate to like Item 2 of 5, and someone else already had submitted feedback for that item (thus it has the "Has feedback" and "Response submitted" indicators)... what does the submit button say: does is say 'Submit' or does it say 'Edit feedback'? Hopefully it says 'Submit' based on what you describe above (and i know that if I am the one that had already entered that feedback that it would say 'Edit Feedback' which makes sense).
There was a problem hiding this comment.
You have a good point here, however the current implementation doesn't make a distinction yet and always say "Edit feedback". It can be a logical defect we tolerate, otherwise lets backlog a bug for now.
There was a problem hiding this comment.
okay, i guess I should add a Note then to the docs that if you were not the annotator to originally submit the feedback, that this button will not edit the feedback but will instead make an additional feedback entry for this item.
anastasiaguspan
force-pushed
the
weave-annotation-q-docs-1869
branch
from
16c1bd3 to
12d68ef
Compare
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 74%, saving 407.0 KB.
|
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 6.4%, saving 5.7 KB.
4 images did not require optimisation. |
dbrian57
left a comment
dbrian57
left a comment
There was a problem hiding this comment.
This is really well structured and thorough! Minor stuff inline.
|
|
||
| You can still provide feedback for an item even if it has already been reviewed by someone else. In this case, although the feedback submission button will still say **Edit feedback**, it will create a new feedback entry with your responses. | ||
| <Note> | ||
| If you submit feedback to an item already reviewed by someone else, your feedback will be stored **in addition to** the original annotator's feedback. |
There was a problem hiding this comment.
Again, I don't this this needs to be a note and can be rewritten to use present tense and more active voice, like this:
| If you submit feedback to an item already reviewed by someone else, your feedback will be stored **in addition to** the original annotator's feedback. | |
| If you submit feedback on an item that has already been reviewed by someone else, Weave stores the feedback **in addition to** the original annotator's feedback. It does not edit or overwrite the original feedback. |
There was a problem hiding this comment.
I fixed the tense, but for now i'm leaving the note because 1. in this case it is intentionally redundant to the printed text (said a different way) - e.g. if they really are scanning right past note boxes they are still safe.
if it wasn't a note box, it would have to be removed because it is redundant - but in this case we need to highlight this because it is kinda like a 'known bug' that they cannot currently address. so i'm trying to catch both cases, those that only read the important notes and those that skip them. (we did this a lot in AWS, knowing the same fact you mentioned, some people don't see note boxes. But general sentiment at AWS was there is a subclass that skims so hard they only see note boxes, so for important stuff we kinda did both. happy to chat this out further and align with the team.)
Co-authored-by: Dan Brian <daniel.brian@gmail.com>
|
Hi @anastasiaguspan so sorry to deliver this message. but in a recent PR, we are going to rename
Change is made from https://github.com/wandb/core/pull/39315 |
3 participants
Description
Adding two new pages under "monitor and collect feedback" -> Annotate:
Testing
mint dev)mint broken-links)Related issues