fix: Add v2 migration and release safeguards - #295
Conversation
|
Warning Review limit reached
Next review available in: 34 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| Pointing v2 at the v1 Redis Service does not make it safe to uninstall the | ||
| v1 release. | ||
|
|
||
| ## Enter single-controller mode |
There was a problem hiding this comment.
I'm not sure that we want to advise even deploying them side by side, in my testing I applied the operator v2 helm chart as an upgrade over the v1 helm release.
There was a problem hiding this comment.
it might requires some pre-upgrade steps to make sure that all the resources are annotated correctly for the transition, but it might be cleaner
| Redis. The uninstall deletes the Redis workload even if the v2 resource calls | ||
| it "external." | ||
|
|
||
| ## Rollback |
There was a problem hiding this comment.
I think if we want to have a rollback path we may need to disable some features on v2, or data created after the upgrade may not be complete.
Summary
-dev.*for internal chart buildsTesting
actionlint .github/workflows/release.yaml .github/workflows/internal-chart-publish.yamlhelm lint --strict deploy/operatormake test