Skip to content

feat: Add weave-trace to OTLP telemetry managed-workload allowlist #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amwarrier wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add weave-trace to OTLP telemetry managed-workload allowlist #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions internal/controller/reconciler/reconcile_v2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,17 @@ var defaultRequeueMinutes = 1
var defaultRequeueDuration = time.Duration(defaultRequeueMinutes) * time.Minute

var managedWorkloadTelemetryApplications = map[string]struct{}{
"api": {},
"executor": {},
"filemeta": {},
"filestream": {},
"flat-run-fields-updater": {},
"glue": {},
"metric-observer": {},
"parquet": {},
"api": {},
"executor": {},
"filemeta": {},
"filestream": {},
"flat-run-fields-updater": {},
"glue": {},
"metric-observer": {},
"parquet": {},
"weave-trace": {},

@danielpanzella danielpanzella Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@casey-coreweave do we still need this list, or did we move the logic into the manifest for this?

@amwarrier amwarrier Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needed. The three managedWorkload*Applications maps here are the only place we express which apps get OTel / statsd / Datadog env injection — the Application manifest struct has no field for this, and the shipped server manifests don't carry a per-app telemetry flag. Moving this to manifest metadata is a good followup, but hasn't been done — cc @casey-coreweave who mentioned we'd like to eventually remove these lists.

"weave-trace-evaluate-model-worker": {},
"weave-trace-worker": {},
}

var managedWorkloadStatsdApplications = map[string]struct{}{
Expand Down
14 changes: 13 additions & 1 deletion internal/controller/reconciler/telemetry_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"testing"

"github.com/stretchr/testify/assert"
apiv2 "github.com/wandb/operator/api/v2"
serverManifest "github.com/wandb/operator/pkg/wandb/manifest"
appsv1 "k8s.io/api/apps/v1"
Expand Down Expand Up @@ -1249,7 +1250,7 @@ func TestInjectManagedWorkloadTelemetryEnvvarsAddsDatadogAgentForDdtraceApps(t *
client := fake.NewClientBuilder().WithScheme(scheme).Build()
wandb := telemetryStatusWandb("wandb-dev-v2", "default", "status-otel-secret")

for _, appName := range []string{"anaconda2", "weave-trace"} {
for _, appName := range []string{"anaconda2"} {
t.Run(appName, func(t *testing.T) {
envVars, err := injectManagedWorkloadTelemetryEnvvars(
context.Background(),
Expand Down Expand Up @@ -1290,6 +1291,17 @@ func TestInjectManagedWorkloadTelemetryEnvvarsAddsDatadogAgentForDdtraceApps(t *
}
}

func TestManagedWorkloadTelemetryApplicationsContainsWeaveTraceApps(t *testing.T) {
for _, name := range []string{
"weave-trace",
"weave-trace-worker",
"weave-trace-evaluate-model-worker",
} {
_, ok := managedWorkloadTelemetryApplications[name]
assert.True(t, ok, "%q should be in the OTel allowlist", name)
}
}

func readyTelemetryResource(gvk schema.GroupVersionKind, name, namespace string) *unstructured.Unstructured {
return newTelemetryResource(gvk, name, namespace, []map[string]any{{"type": "Available", "status": "True"}})
}
Expand Down
Loading