fix(weave): preserve user IDs in object creation - #7650
Open
gtarpenning wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
gtarpenning
marked this pull request as ready for review
July 28, 2026 22:02
jtschoonhoven
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before / after
Before, a DatasetCreateReq carrying wb_user_id reached the backend helper, but the generated ObjSchemaForInsert hardcoded the field to None. The same happened for ops, scorers, and evaluations, while generated scorer/evaluation ops omitted the field entirely.
After, the adapter converts the external ID to its internal representation once and every object version emitted by these four creation paths stores that ID in both ClickHouse and the in-memory test backend.
Testing
Scope
This intentionally does not add global non-null assertions, change worker payload contracts, or backfill historical rows.