chore(weave): minor cleanup/fixes in weave.evaluation - #7675
Open
tonyyli-wandb wants to merge 1 commit into
Open
chore(weave): minor cleanup/fixes in weave.evaluation#7675tonyyli-wandb wants to merge 1 commit into
weave.evaluation#7675tonyyli-wandb wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
tonyyli-wandb
force-pushed
the
tonyyli/chore-weave-minor-cleanup-fixes-in-evaluation-subpackage
branch
from
July 31, 2026 20:42
b5679a1 to
1902d66
Compare
tonyyli-wandb
commented
Jul 31, 2026
Comment on lines
+61
to
+62
| # Iterate over a shallow copy. Otherwise, cleanup can drop items mid-iteration. | ||
| for eval_logger in list(_active_evaluation_loggers): |
Contributor
Author
There was a problem hiding this comment.
note: fixes what looks like a (minor/rare) bug
tonyyli-wandb
force-pushed
the
tonyyli/chore-weave-minor-cleanup-fixes-in-evaluation-subpackage
branch
2 times, most recently
from
July 31, 2026 20:51
7b1552c to
793229f
Compare
tonyyli-wandb
changed the title
weave.evaluation
tonyyli-wandb
marked this pull request as ready for review
July 31, 2026 21:01
tonyyli-wandb
force-pushed
the
tonyyli/chore-weave-minor-cleanup-fixes-in-evaluation-subpackage
branch
from
July 31, 2026 22:22
793229f to
563a476
Compare
tonyyli-wandb
force-pushed
the
tonyyli/chore-weave-minor-cleanup-fixes-in-evaluation-subpackage
branch
from
July 31, 2026 23:12
563a476 to
6f21885
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor, incidental cleanup in
weave.evaluationssubpackage while working on other things.Includes at least one small bugfix: see inline comment below.
Testing
How was this PR tested?