feat(weave): propagate Custom Runtime conversation context - #7696
Draft
mattliu-mygit wants to merge 1 commit into
Draft
feat(weave): propagate Custom Runtime conversation context#7696mattliu-mygit wants to merge 1 commit into
mattliu-mygit wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #7688 with the first, independently mergeable slice: conversation context propagation only.
Custom Runtimes can emit their own internal spans, but previously they did not receive the conversation ID used by the Playground request. Those spans therefore could not reliably join the same chronological conversation.
This PR:
X-Weave-Conversation-Idruntime header, overriding any configured header with that name_metachannelThis deliberately preserves existing tracing behavior. Both
track_llm_call=trueandtrack_llm_call=falsecontinue to mean what they mean today; this PR does not choose a new Custom Runtime logging default or add UI policy.Testing
146 passedacross:tests/trace/test_chat_completions.pytests/trace_server/test_llm_completion.pytests/trace_server/test_clickhouse_trace_server_batched.pytests/trace_server/test_async_clickhouse_trace_server.pytests/trace_server/test_custom_provider.pyty checkThe focused coverage includes generated and reused IDs, streaming and non-streaming responses, configured-header override, header-safe encoding, tracked and untracked requests, and provider switching.