feat(weave): allow score tracing to be disabled in imperative evals - #7700
Draft
domphan-wandb wants to merge 1 commit into
Draft
feat(weave): allow score tracing to be disabled in imperative evals#7700domphan-wandb wants to merge 1 commit into
domphan-wandb wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
2 tasks
domphan-wandb
force-pushed
the
dom/imper-eval-disable-score-tracing
branch
from
August 7, 2026 20:01
f4754a7 to
2d6aa7a
Compare
kelu-wandb
approved these changes
Aug 7, 2026
kelu-wandb
left a comment
kelu-wandb
left a comment
Contributor
There was a problem hiding this comment.
approving with suggestion
| """Internal-only: Merge potential caller-provided fields into the eval meta.""" | ||
| self._score_meta = {**eval_meta, **IMPERATIVE_SCORE_META_MARKER} | ||
|
|
||
| def _scores_untraced(self) -> bool: |
Contributor
There was a problem hiding this comment.
I would lean toward calling this _scores_traced and using a not at the caller. Positive names are less confusing than negative ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes WB-37813
This PR adds an argument that disables score tracing for imperative evals. The score tracing was adding additional overhead that we didn't need for eval tables.
Testing