feat(weave_ts): accept JSON tool values - #7702
Merged
Merged
Conversation
rgao-coreweave
marked this pull request as draft
August 6, 2026 22:29
rgao-coreweave
changed the title
ro31337
reviewed
Aug 6, 2026
| if (typeof value === 'string') { | ||
| return value; | ||
| } | ||
| try { |
Contributor
There was a problem hiding this comment.
I see the PR is draft, so apologies if it is too early to ask and if this is something you had in mind already.
Is there anything that prevents a tool argument or result containing a secret or customer data from being serialized into these span attributes in prod?
Should we make content capture opt-in or redact it before recording?
Contributor
Author
There was a problem hiding this comment.
Thanks, marking the PR ready for review.
Good call out that we should add pii redaction to the tool args. However I don't think we have this capability to do so in typescript yet.
rgao-coreweave
marked this pull request as ready for review
August 6, 2026 23:01
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ro31337
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JsonValueandJsonObjecttypes for JSON-compatible tool dataToolInit.argsTool.end({result})and serialize structured values inside the SDKresult,error, anderrorTypetogether when a tool endsTool.resultcompatibilityTesting
pnpm exec jest --runInBand src/__tests__/genai(9 suites, 101 tests, 13 snapshots)pnpm exec jest --runInBand src/__tests__/genai/tool.test.ts(8 tests)pnpm run typecheck:cjspnpm run typecheck:esmpnpm run lintpnpm run prettier-checkBreaking changes
None. Existing string arguments and mutable
Tool.resultassignments continue to work.Related