feat(deploy-v2): add --enable-*-operator flags for bundled operators - #100
Open
kkaushik-wandb wants to merge 3 commits into
Open
feat(deploy-v2): add --enable-*-operator flags for bundled operators#100kkaushik-wandb wants to merge 3 commits into
kkaushik-wandb wants to merge 3 commits into
Conversation
Add LoadDisabledSubcharts/SaveDisabledSubcharts to read and write a disabled-subcharts key on the wsm-deployment-marker ConfigMap, preserving other marker data so subchart opt-outs survive a later flag-less upgrade. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…charts
Add --enable-{moco,redis,seaweedfs,clickhouse}-operator (default true) so users
bringing their own managed services can skip the bundled operator subcharts;
each disable sets both <subchart>.enabled and wandb-operator.operators.<key>,
and the choice persists via the deployment marker so flag-less upgrades honor it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add the four flags to the deploy-v2 operator reference with a bring-your-own example and a note that the choices persist in the deployment marker. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe ChangesBundled operator enablement
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant operatorDeployCmd
participant performDeploy
participant DeployOperator
participant HelmRelease
participant DeploymentMarker
operatorDeployCmd->>DeploymentMarker: load disabled-subchart state
operatorDeployCmd->>performDeploy: resolved enablement booleans
performDeploy->>DeployOperator: bundled operator options
DeployOperator->>HelmRelease: apply subchart and controller settings
performDeploy->>DeploymentMarker: save disabled-subchart state
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds four typed flags to
wsm deploy-v2 operatorso users bringing their own managed services can skip the bundled subcharts, instead of hand-editing chart values.true):--enable-moco-operator,--enable-redis-operator,--enable-seaweedfs-operator,--enable-clickhouse-operator. A normal install needs none of them.<subchart>.enabled=false(stops the operator pod installing) andwandb-operator.operators.<key>=false(stops the W&B controller managing that service), applied viasetNestedafter the mirror/OpenShift blocks so they win and compose without clobbering sibling keys.wsm-deployment-markerConfigMap (disabled-subchartskey), so a later flag-lesswsm deploy-v2 operatorupgrade keeps a subchart disabled; passing the flag again with=truere-enables it, andoperator destroyclears the state. An explicit flag on any run always wins over the persisted value.--enable-seaweedfs-operator=falsealso dropsprometheus-operator-crds, which shares the same chart condition.Test Plan
make build— compiles cleanmake lint—go vet+ golangci-lint clean (0 issues)make fmt— no diffgo mod tidy— no diffhelm get values, pod state, and the marker ConfigMap:=false→ that subchart's pod gone, others running=false→ all gone,operators.*all false (no clobber)=true→ subcharts return, marker clearedoperator destroy→ marker state clearedRequirements
make lint)make fmtleaves no diff)go.mod/go.sumtidy (go mod tidyleaves no diff)docs/,docs/reference/commands.md,docs/reference/cr-fields.md) /CLAUDE.mdupdated if behavior changedSummary by CodeRabbit
New Features
Documentation