ci: run checks on operator-v2 and add a build job - #72
Open
amarkov-cw wants to merge 1 commit into
Open
Conversation
amarkov-cw
requested review from
adityachoudhari26,
dacbd,
danielpanzella,
j7m4,
jsbroks,
mwhooker,
theishshah and
zacharyblasczyk
as code owners
June 17, 2026 17:49
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
amarkov-cw
force-pushed
the
amarkov/fix-deploy-v2-telemetry-callsite
branch
from
June 17, 2026 19:24
c92cdd9 to
c92f92b
Compare
amarkov-cw
changed the title
checks.yaml only triggered on `main` (long dead), so no CI ran on operator-v2 PRs/pushes -- which is how a non-compiling commit landed (since fixed in c92f92b). Run on operator-v2 too, add an explicit `go build ./...` job to gate compile breaks, and bump Go 1.25->1.26 to match go.mod.
jthakkar04
force-pushed
the
amarkov/fix-deploy-v2-telemetry-callsite
branch
from
July 17, 2026 22:11
053896c to
a5d6170
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI (
.github/workflows/checks.yaml) only triggers onmain(push + pull_request). Butmainis dead and all work happens onoperator-v2, so no checks run on anyoperator-v2PR or push.That's how a non-compiling commit reached
operator-v2HEAD: the telemetry refactor (#71) changedoperator.DeployOperator's signature but missed the call site inperformDeploy()(deploy_v2.go:626), and nothing caught it. (The compile break itself was already fixed separately in c92f92b by @dgreeninger-wandb — this PR is just the CI hardening so it can't recur.)Change
operator-v2in addition tomain.go build ./...job to gate compile breaks. (The existinggolangci-lintjob also type-checks and would have caught this — but only if it ran; a dedicated build step is unambiguous.)1.25→1.26to matchgo.mod.Note
Surfaced while self-onboarding through the WSM install docs (
rhel-fix) as a new self-managed customer: a freshoperator-v2checkout didn't compile, and there was no CI on the branch to have caught it.🤖 Generated with Claude Code