fix: patch Grafana telemetry CRD validation - #94
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing in favor of the fix at the dependency owner: wandb/operator#274 upgrades Grafana Operator to 5.22.2, which contains the upstream Kubernetes CEL compatibility fix. The WSM-side chart mutation is no longer the intended solution. |
What changed
self.continueto Kubernetes' reserved-keyword form,self.__continue__.Root cause
Operator chart
2.0.0-beta.1bundles Grafana Operator chart5.21.4. Its GrafanaNotificationPolicy CRD usescontinue, a CEL reserved keyword, without Kubernetes' required escaping. Kubernetes versions before 1.32 reject the CRD while compiling the validation rule, causing full-telemetry deployment to fail before the W&B operator is installed.This applies the same expression change as the upstream Grafana Operator fix. The workaround is narrowly scoped to the exact CRD filename and expression, so a future operator chart containing the upstream fix is left unchanged.
Impact
Full telemetry installations from Watchtower/WSM can deploy to Kubernetes 1.30. Telemetry
offandforwardare unchanged.Validation
go test ./...golangci-lint run --timeout=5m --concurrency=4 --max-same-issues=20operator-2.0.0-beta.1archive downloaded by Watchtower.