feat: add support for read CLI command#69
Conversation
Signed-off-by: Antonio Mindov <amindov98@gmail.com>
|
Nice PR! Any chance you can also add support for getting the secret reference in a new class method? Then everything in the user workflow can be done in python too? |
|
Also is this only support by a certain cli version? |
Thanks! I'm not sure if that's something users would want to do as I imagine that this will be used to fill in secrets which are already set from somewhere. But even so there is a way to get the reference with the current API:
The read command is available for 2.0 and up (ref: https://app-updates.agilebits.com/product_history/CLI2#2.0.0:~:text=Secfault%20Security.%20%7B2183%7D-,2.0.0,-(build%20%232000019)%20%E2%80%93%20released) |
Ok great! So I would also suggest some clear example(s) in the README then to make sure users know how to use! Since it's v2+ then we are good, I do intend to update with a fixed version we support since we keep getting issues with backwards compatibility and users installing the cli as they wish. |
dtpryce
left a comment
There was a problem hiding this comment.
As mentioned in comments - please add some example(s) in README
|
Would this also resolve the need for |
Signed-off-by: Antonio Mindov <amindov98@gmail.com>
|
Added the README updates. I'm not sure this has anything to do with the |
|
This PR adds a capability which I couldn't find elsewhere in this module - reading file attachments from regular secrets. It seems the only way to do it currently is with the CLI command |
inspired by adnandaut and my needs.
fixes #66 by adding support for the read CLI command
this can be tested like this: