Skip to content

fix(sessions): 重复创建 Transport 导致内存溢出 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aruelius wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(sessions): 重复创建 Transport 导致内存溢出 #64

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c1c771
fix(sessions): 重复创建 `Transport` 导致内存溢出
Aruelius Mar 28, 2024
a5cf141
使用 `sync.Once` 保证赋值语句只执行一次
Aruelius Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions sessions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,11 @@ var disableRedirect = func(request *http.Request, via []*http.Request) error {
return http.ErrUseLastResponse
}

var (
DEFAULT_TRANSPORT *http.Transport // 默认 Transport
defineTransport sync.Once
)

const (
DEFAULT_REDIRECT_LIMIT = 30 // 默认redirect最大次数
DEFAULT_TIMEOUT = 10 // 默认client响应时间
Expand All @@ -151,14 +156,20 @@ func NewSession() *Session {
}
cookies, _ := cookiejar.New(nil)
session.Cookies = cookies
session.transport = &http.Transport{
TLSClientConfig: &utls.Config{
InsecureSkipVerify: session.Verify,
OmitEmptyPsk: true,
},
DisableKeepAlives: false, // 这里问题很严重
}
session.request = &http.Request{}

defineTransport.Do(func() {
// Transports should be reused instead of created as needed.
// Transports are safe for concurrent use by multiple goroutines.
DEFAULT_TRANSPORT = &http.Transport{
TLSClientConfig: &utls.Config{
InsecureSkipVerify: session.Verify,
OmitEmptyPsk: true,
},
DisableKeepAlives: false,
}
})
session.transport = DEFAULT_TRANSPORT

session.client = &http.Client{
Transport: session.transport,
CheckRedirect: nil,
Expand Down