Removed findomnode which will be deprecated.#76
Open
falcoagustin wants to merge 1 commit intowangzuo:masterfrom
Open
Removed findomnode which will be deprecated.#76falcoagustin wants to merge 1 commit intowangzuo:masterfrom
falcoagustin wants to merge 1 commit intowangzuo:masterfrom
Conversation
Author
|
@wangzuo Could you check it out ? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method
findDOMNodehas been deprecated in later versions of react see here. This PR suggests a way to do exactly the same using refs in order not to get an error when executing and for later compatibility.Made with ❤️
Thanks!
PD: Any comment is more than appreciated.