Remove PushFeedback integration#100
Merged
Merged
Conversation
Removes the 'Was this helpful?' PushFeedback widget from both the Starlight footer (every docs page) and the standalone Scalar API reference at /api. Per Hong Yi: PushFeedback wasn't on a team plan and submissions were sparse, so it can be removed for now and re-introduced later with a Warp-built tool. Changes: - Delete src/components/FeedbackButtons.astro (purely PushFeedback). - Strip FeedbackButtons reference + comments from src/components/FeedbackFooter.astro. The custom footer still drops EditLink + LastUpdated relative to Starlight's default (preserves current visible layout). - Remove FeedbackButtons usage, comments, and .api-feedback-* styles from src/pages/api.astro. Theme script comments updated to drop PushFeedback's contract references (html[data-theme] is retained for the first-paint canvas color rules). - Drop PUBLIC_PUSHFEEDBACK_PROJECT_ID envField from astro.config.mjs and .env.example. - Remove https://app.pushfeedback.com from the connect-src directive in all three vercel.json CSP entries. Verified with `npm run build` (319 pages built clean). Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR removes the PushFeedback widget from the docs footer and API reference, deletes its public env field/example, and tightens CSP by dropping the PushFeedback connect-src host.
Concerns
- No blocking correctness, spec, or security concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
The border-top + padding-top on the footer were originally added to visually separate the PushFeedback widget from the page content. With the widget gone (#100), the divider no longer separates anything meaningful, so drop it. The pagination card and Starlight credits keep their own spacing via the existing footer gap + margin-top. Co-Authored-By: Oz <oz-agent@warp.dev>
rachaelrenk
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the PushFeedback "Was this helpful?" widget from both the Starlight footer (every docs page) and the standalone Scalar API reference at
/api.Context: Hong Yi shared that PushFeedback wasn't on a team plan and submissions were sparse, so we can drop it for now and bring back a Warp-built equivalent later.
What's removed
src/components/FeedbackButtons.astro— purely the PushFeedback widget, deleted outright.FeedbackButtonsusage + related comments insrc/components/FeedbackFooter.astro. The footer override stays so EditLink/LastUpdated remain hidden (preserves current visible layout).<FeedbackButtons />usage, related comments, and.api-feedback-*styles insrc/pages/api.astro. Thehtml[data-theme]MutationObserver/contract is retained because the first-paint canvas color CSS keys off it (independent of PushFeedback).PUBLIC_PUSHFEEDBACK_PROJECT_IDenvFieldfromastro.config.mjsand the matching entry in.env.example.https://app.pushfeedback.comfrom theconnect-srcCSP directive in all threevercel.jsonheader blocks.What stays the same
/apireference is unchanged aside from the missing widget; theme-sync scripts and first-paint canvas color rules still work.Validation
npm run buildsucceeds (319 pages, clean).grep -ri "pushfeedback\|FeedbackButtons" .and on the builtdist/directory return zero matches.Conversation: https://staging.warp.dev/conversation/876a0dd7-f640-4891-abf3-43a7b90dc7c5
Run: https://oz.staging.warp.dev/runs/019e3ec6-c98e-7cfa-bb89-bb69bc01144f
This PR was generated with Oz.