Skip to content

docs: point validate_ui_refs at warpdotdev/warp - #448

Merged
rachaelrenk merged 4 commits into
mainfrom
rrenk/validate-ui-refs-warp-repo
Aug 4, 2026
Merged

docs: point validate_ui_refs at warpdotdev/warp#448
rachaelrenk merged 4 commits into
mainfrom
rrenk/validate-ui-refs-warp-repo

Conversation

@rachaelrenk

@rachaelrenk rachaelrenk commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

The validate_ui_refs skill was the last straggler still pointing at warp-internal. Its description, prose, --warp-internal-path flag, and WARP_INTERNAL_PATH env var all referenced the private repo, even though the refresh-ui-paths workflow already clones and extracts from the public warpdotdev/warp repo.

That was a real inconsistency someone was going to hit: the SKILL.md "Automated refresh" section already stated warpdotdev/warp is the extraction source, while the options list and manual-trigger instructions told you to pass --warp-internal-path /path/to/warp-internal.

This aligns validate_ui_refs with missing_docs, which already accepts both repos via a deprecated alias.

Changes

.agents/skills/validate_ui_refs/validate_ui_refs.py

  • Added --warp as the primary flag. --warp-internal-path is kept as a deprecated alias sharing the same dest, matching the pattern missing_docs uses.
  • Added a resolve_warp_repo() helper with a documented precedence chain: explicit flag, then WARP_REPO_PATH, then the deprecated WARP_INTERNAL_PATH, then sibling auto-detect preferring ../warp and falling back to ../warp-internal.
  • Removed the hardcoded ../warp-internal default.
  • Renamed internal parameters and docstrings from warp_internal to warp_repo, and renamed the synthetic self-test fixture directory to warp.
  • Improved the not-found error to name both --warp and WARP_REPO_PATH.
  • Extended --self-test with a fourth case asserting the deprecated flag and env var still resolve, and that WARP_REPO_PATH wins over WARP_INTERNAL_PATH.

.agents/skills/validate_ui_refs/SKILL.md

  • Updated the frontmatter description, intro, options list, refresh instructions, manual-trigger example, and dependencies to reference the public warp client repo.
  • Documented the deprecated flag and env var alongside the new ones.

.github/workflows/refresh-ui-paths.yml

  • Updated the trigger and permissions comments, and switched the Oz agent prompt to --warp /workspace/warp.

.github/workflows/ci.yml

  • Updated the self-test comment describing the synthetic fixture.

Backwards compatibility

Nothing breaks. --warp-internal-path and WARP_INTERNAL_PATH continue to work, and a warp-internal sibling checkout is still auto-detected as a fallback. The new self-test case locks that behavior in.

Verification

  • --self-test passes, including the new precedence coverage.
  • Verified at runtime that --warp-internal-path, WARP_INTERNAL_PATH, and WARP_REPO_PATH precedence all behave correctly.
  • A full --all scan runs clean: 347 files, 0 path issues, 0 format issues.

Notes for reviewers

The extraction source paths are unchanged, since both repos share the app/src/settings_view/ layout.

The scan also surfaces 12 pre-existing Command Palette findings. They are unrelated to this change; valid_paths.json is untouched and no validation logic changed.

Post-merge validation

At review time this change had not been exercised end to end, because --refresh-valid-paths needs a warp checkout that wasn't available locally. It has since been confirmed.

The refresh-ui-paths workflow was triggered manually via workflow_dispatch against merged main, dispatching cloud agent run 019fce84-176d-7aaa-9e82-b07457f1974b. The agent reported:

Refreshed valid_paths.json from /workspace/warp with validate_ui_refs.py --refresh-valid-paths. After stripping generated_at, the snapshot matched the previous version (25 sections, 3 umbrellas, 4 deprecated, 164 commands), so no validation/fix PR was needed.

This confirms the new --warp flag resolves correctly and that the Rust parsers find both settings_view/mod.rs and the EditableBinding registrations in the public repo. The unchanged snapshot is the expected no-op outcome.

Follow-up

The 12 Command Palette findings were investigated after merge and turned out to be two distinct problems:

Co-Authored-By: Oz oz-agent@warp.dev

The validate_ui_refs skill still referenced warp-internal in its
description, prose, --warp-internal-path flag, and WARP_INTERNAL_PATH
env var, even though the refresh workflow already extracts from the
public warpdotdev/warp repo. This aligns it with missing_docs, which
already supports both via a deprecated alias.

- Add --warp as the primary flag; keep --warp-internal-path as a
  deprecated alias sharing the same dest (matches missing_docs)
- Add resolve_warp_repo(): explicit flag > WARP_REPO_PATH >
  deprecated WARP_INTERNAL_PATH > sibling ../warp, then ../warp-internal
- Drop the hardcoded ../warp-internal default
- Rename internal params/docstrings warp_internal -> warp_repo
- Extend the self-test to cover the deprecated flag and env var
- Update SKILL.md, refresh-ui-paths.yml, and ci.yml references

Co-Authored-By: Oz <oz-agent@warp.dev>
@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 4, 2026 4:25pm

Request Review

@cla-bot cla-bot Bot added the cla-signed label Jul 31, 2026
@oz-for-oss

oz-for-oss Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@rachaelrenk

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR updates the validate_ui_refs skill and refresh workflow to use the public warpdotdev/warp checkout as the primary source for UI-path extraction, while preserving deprecated warp-internal flag/env/sibling fallback behavior. The implementation keeps the extraction paths unchanged, adds centralized repository resolution, updates documentation/workflow prompts, and extends self-test coverage for the new precedence behavior.

Concerns

  • No blocking concerns found in the attached diff. No approved or repository spec context was provided, and the security pass did not identify issues.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@rachaelrenk rachaelrenk self-assigned this Aug 1, 2026
…r skill

Co-Authored-By: Oz <oz-agent@warp.dev>
@rachaelrenk
rachaelrenk merged commit 8aec07b into main Aug 4, 2026
8 checks passed
@rachaelrenk
rachaelrenk deleted the rrenk/validate-ui-refs-warp-repo branch August 4, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants