docs: point validate_ui_refs at warpdotdev/warp - #448
Conversation
The validate_ui_refs skill still referenced warp-internal in its description, prose, --warp-internal-path flag, and WARP_INTERNAL_PATH env var, even though the refresh workflow already extracts from the public warpdotdev/warp repo. This aligns it with missing_docs, which already supports both via a deprecated alias. - Add --warp as the primary flag; keep --warp-internal-path as a deprecated alias sharing the same dest (matches missing_docs) - Add resolve_warp_repo(): explicit flag > WARP_REPO_PATH > deprecated WARP_INTERNAL_PATH > sibling ../warp, then ../warp-internal - Drop the hardcoded ../warp-internal default - Rename internal params/docstrings warp_internal -> warp_repo - Extend the self-test to cover the deprecated flag and env var - Update SKILL.md, refresh-ui-paths.yml, and ci.yml references Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR updates the validate_ui_refs skill and refresh workflow to use the public warpdotdev/warp checkout as the primary source for UI-path extraction, while preserving deprecated warp-internal flag/env/sibling fallback behavior. The implementation keeps the extraction paths unchanged, adds centralized repository resolution, updates documentation/workflow prompts, and extends self-test coverage for the new precedence behavior.
Concerns
- No blocking concerns found in the attached diff. No approved or repository spec context was provided, and the security pass did not identify issues.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
…r skill Co-Authored-By: Oz <oz-agent@warp.dev>
…4-monitor skill" This reverts commit 7276ca8.
Summary
The
validate_ui_refsskill was the last straggler still pointing atwarp-internal. Its description, prose,--warp-internal-pathflag, andWARP_INTERNAL_PATHenv var all referenced the private repo, even though therefresh-ui-pathsworkflow already clones and extracts from the publicwarpdotdev/warprepo.That was a real inconsistency someone was going to hit: the SKILL.md "Automated refresh" section already stated
warpdotdev/warpis the extraction source, while the options list and manual-trigger instructions told you to pass--warp-internal-path /path/to/warp-internal.This aligns
validate_ui_refswithmissing_docs, which already accepts both repos via a deprecated alias.Changes
.agents/skills/validate_ui_refs/validate_ui_refs.py--warpas the primary flag.--warp-internal-pathis kept as a deprecated alias sharing the samedest, matching the patternmissing_docsuses.resolve_warp_repo()helper with a documented precedence chain: explicit flag, thenWARP_REPO_PATH, then the deprecatedWARP_INTERNAL_PATH, then sibling auto-detect preferring../warpand falling back to../warp-internal.../warp-internaldefault.warp_internaltowarp_repo, and renamed the synthetic self-test fixture directory towarp.--warpandWARP_REPO_PATH.--self-testwith a fourth case asserting the deprecated flag and env var still resolve, and thatWARP_REPO_PATHwins overWARP_INTERNAL_PATH..agents/skills/validate_ui_refs/SKILL.md.github/workflows/refresh-ui-paths.yml--warp /workspace/warp..github/workflows/ci.ymlBackwards compatibility
Nothing breaks.
--warp-internal-pathandWARP_INTERNAL_PATHcontinue to work, and awarp-internalsibling checkout is still auto-detected as a fallback. The new self-test case locks that behavior in.Verification
--self-testpasses, including the new precedence coverage.--warp-internal-path,WARP_INTERNAL_PATH, andWARP_REPO_PATHprecedence all behave correctly.--allscan runs clean: 347 files, 0 path issues, 0 format issues.Notes for reviewers
The extraction source paths are unchanged, since both repos share the
app/src/settings_view/layout.The scan also surfaces 12 pre-existing Command Palette findings. They are unrelated to this change;
valid_paths.jsonis untouched and no validation logic changed.Post-merge validation
At review time this change had not been exercised end to end, because
--refresh-valid-pathsneeds a warp checkout that wasn't available locally. It has since been confirmed.The
refresh-ui-pathsworkflow was triggered manually viaworkflow_dispatchagainst mergedmain, dispatching cloud agent run019fce84-176d-7aaa-9e82-b07457f1974b. The agent reported:This confirms the new
--warpflag resolves correctly and that the Rust parsers find bothsettings_view/mod.rsand theEditableBindingregistrations in the public repo. The unchanged snapshot is the expected no-op outcome.Follow-up
The 12 Command Palette findings were investigated after merge and turned out to be two distinct problems:
label=,title=, a375pxCSS value) and a prompt example inside a fenced code block. Fixed in docs: stop validate_ui_refs flagging JSX props and code fences as Command Palette commands #472._extract_command_palette_commands()reads only two Rust source files. The docs are correct and the tool is incomplete; this remains open.Co-Authored-By: Oz oz-agent@warp.dev