docs: editorial review pass on Warp Agent CLI launch docs - #473
docs: editorial review pass on Warp Agent CLI launch docs#473rachaelrenk wants to merge 4 commits into
Conversation
Follow-up review of the CLI launch documentation merged in #411, covering the pages that landed late (overview, quickstart) plus a holistic pass for consistency across all nine pages. Overview: - Rewrite Key features descriptions that were sentence fragments or unclear - Restructure "Logging in and out" into three scannable procedures - Reword automatic updates and split the opt-out into its own paragraph Consistency fixes found while reviewing: - Normalize mixed bullet markers in input-and-shell-commands.mdx - Align "The CLI updates automatically" phrasing across three pages - Unbold Related pages links and add missing trailing periods - Remove the one em dash in instructional text and a British spelling - Name the autoupdate setting key and deep-link it from the reference Flags a page title vs. sidebar label mismatch in configuration.mdx for confirmation rather than changing it. Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR makes an editorial consistency pass across the Warp Agent CLI documentation, tightening key feature descriptions, login/update wording, related-page formatting, and bullet markers. I did not find correctness, security, link, or spec-alignment issues in the annotated diff.
Concerns
- No blocking concerns found. No approved or repository spec context was provided, so there was no material spec contract to enforce.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Second review round, focused on the quickstart.
- Number the step headings ("## 1. Install...") to match the sibling Oz CLI
and API/SDK quickstarts; ours was the only quickstart not numbering steps.
Convert the nested numbered lists to prose so steps aren't double-numbered.
- Put the install commands in Tabs/TabItem for macOS+Linux and Windows,
matching the pattern in getting-started/quickstart/installation-and-setup.
- Add a sign-up link to the account prerequisite for developers new to Warp,
and note the CLI doesn't require the Warp app.
- Tighten the login section along the lines of the Oz CLI quickstart's
authenticate step, drop the colon from the start-screen sentence, and
reword the API key pointer.
- Update the inbound /cli/quickstart/#log-in anchor, now #2-log-in.
Co-Authored-By: Oz <oz-agent@warp.dev>
Third review round. The CLI descriptions showed a pattern of filler openers and page-describing phrasing, so this fixes the guidance gap that allowed it, then applies the result. Guidance gap: - AGENTS.md contradicted itself, saying "1-2 sentences" in the Frontmatter section and "50-160 characters" in the SEO section. Two sentences almost always exceeds 160. Standardized on one sentence, 50-160 characters. - Added a "Description rules" and "Descriptions by content type" section to AGENTS.md as the source of truth, with correct and incorrect examples for conceptual, procedural, quickstart, reference, troubleshooting, FAQ, feature doc, and guide pages. - Templates carried thin, inconsistent one-line hints; only guide-page mentioned the character budget and two had no example. All eight now give type-specific direction and point at AGENTS.md. - The draft_* skills said nothing about descriptions. All eight now carry a short rule with examples and a pointer to AGENTS.md. Applied to the CLI pages: - agent-conversations: opened with "Learn about" and was the only p- agent-conversations: opened with "Learn abontence described the pag- agent-conversations: opened with "Learon:- agent-convst- agent-conversations: opened with "Learn about" and was the only p- agenence: was a noun fragment rather than a verb-led summary. All nine CLI descriptions now pass one sentence, 50-160 characters, no filler opener. Co-Authored-By: Oz <oz-agent@warp.dev>
Top-to-bottom clarity pass on the reference page. Concreteness: - "--api-key ... useful on hosts where a browser sign-in is inconvenient" named no actual situation. Now names CI runners and remote servers. - The provider-key flags described their argument in prose. Both now show <provider> syntax per the style guide, plus a concrete example. - --set/--clear-provider-api-key said "securely stores" without saying where. Both now say the device's secure storage, and that Warp never stores provider keys on its servers. - --auto-approve said "The default applies only to that launch"; "the default" had no clear referent. - WARP_TUI_DISABLE_AUTOUPDATE said "for that launch" with no antecedent. Accuracy and consistency: - The platform note claimed bindings are "identical" across all three platforms and then listed a Windows-only binding. Now states the exception. - Approvals: "Confirm the selected response" read as the agent's response rathe rathe rathe rathe rathe rathe rathe rathe rathe -use action" used a term defined nowhere in the docs used a ter control: Ctrl+C listed two behaviors without saying which applied when. Now distinguishes a command you started from one the agent is running. when. Now distinguishes a command you started from one the agent is rocs say orchestrator, and omitted Shift+left/right and Ctrl+C. Added both. - /skills said "Invoke a skill"; it opens a browser and inserts a skill. - Ctrl+Y said "Paste", which collides with clipboard paste. Now "Rei- Ctrl+Y said "Paste", which cro- Ctrl+Y said "Paste", which collides with clipboard paste. Now "iles. - Alphabetized the command-line flags, matching the slash command table and the reference drafting rules. the reference drafting n the reference drafting rules. the reference drafting n the refe a the reference drafting rules. the reference drafting n the reference dntion number. Co-Authored-By: Oz <oz-agent@warp.dev>
| @@ -139,7 +151,7 @@ Skills also appear in the same menu under their own names, so you can invoke a s | |||
| Press `?` on an empty input to open the contextual shortcuts panel inside the CLI. The tables below list the default bindings. | |||
There was a problem hiding this comment.
Question for the CLI engineers: this says "the default bindings," which implies keybindings are customizable. I couldn't find anything in the CLI docs describing how to customize them, and configuration.mdx doesn't cover a keymap setting.
If they aren't customizable, we should drop "default" so we don't imply a feature that doesn't exist. If they are, let's document where to configure them and link it from here.
Leaving as-is pending confirmation.
Summary
A second, top-to-bottom editorial review of the Warp Agent CLI launch documentation that shipped in #411. The first review happened before the overview and quickstart were finished, and engineering changes were still landing, so this pass re-reads all nine pages holistically.
Four review rounds have landed so far: an initial pass over all nine pages, a quickstart restructure, a frontmatter description pass that also fixed the underlying guidance gap, and a clarity pass over the reference page. Further rounds will be committed here.
Changes
Overview (
cli/index.mdx)WARP_TUI_DISABLE_AUTOUPDATEper-launch option, which the reference documented but the overview omitted.Quickstart (
cli/quickstart.mdx)## 1. Install the Warp Agent CLI). Every other quickstart in the repo numbers its steps; ours was the only one using unnumbered sections with numbered lists inside. Converted those nested lists to prose so steps aren't double-numbered. This matches the sibling Oz CLI quickstart and the API/SDK quickstart.Tabs/TabItemfor macOS and Linux vs. Windows, matching the pattern already used ingetting-started/quickstart/installation-and-setup.mdx.Renumbering the headings changed the login anchor, so the inbound
/cli/quickstart/#log-inlink inindex.mdxwas updated to#2-log-in.Reference (
cli/reference.mdx)A top-to-bottom review for vague or unclear wording.
Concreteness:
--api-keysaid it was "useful on hosts where a browser sign-in is inconvenient," which names no actual situation. It now names CI runners and remote servers.<provider>syntax per the style guide, plus a concrete example.--auto-approvesaid "The default applies only to that launch," where "the default" had no clear referent. Same problem with "for that launch" onWARP_TUI_DISABLE_AUTOUPDATE.general.autoupdate_enabledand deep-links to the settings file section.Accuracy and consistency:
Ctrl+Clisted two behaviors without saying which applied when. It now distinguishes a command you started from one the agent is running.Shift+←/Shift+→andCtrl+C, both documented on the orchestration page. Added./skillssaid "Invoke a skill," but it opens a browser and inserts the skill into the input.Ctrl+Ysaid "Paste," which collides with clipboard paste. Now "Reinsert."Other CLI pages
agent-conversations.mdxwas the only page bolding its Related pages links. The style guide says to avoid redundant bold prefixes when the link text already carries the context.cloud-and-orchestration.mdxhad the only em dash in the nine pages, in instructional text where the style guide prohibits it, plus the British "cancelling" where the rest of the docs use US spelling. Both rewritten.configuration.mdxwas the only Related pages list missing trailing periods. It also picked up a# REVIEW:frontmatter comment flagging that the page title is "Customizing the Warp Agent CLI" while the sidebar label is "Configuration," and that cross-references use four different names for the page. Flagged rather than changed, pending confirmation on whether the mismatch is intentional.input-and-shell-commands.mdxmixed-and*bullet markers across sections. All bullets now use*, matching the other eight pages and the style guide example.Cross-page consistency
Eon the permissions page andeon two others. Standardized on uppercaseE.Authoring guidance for frontmatter descriptions
The CLI descriptions showed a pattern of filler openers and page-describing phrasing, so this round fixed the guidance gap that allowed it, then applied the result.
Guidance, in
AGENTS.md, the templates, and thedraft_*skills:AGENTS.mdcontradicted itself: the Frontmatter section said "1-2 sentences" while the SEO section said "50-160 characters." Two sentences almost always exceeds 160, which is likely why descriptions drifted. Standardized on one sentence, 50-160 characters.AGENTS.mdas the source of truth, with correct and incorrect examples for all eight content types.guide-pagementioned the character budget, andconceptualandproceduralhad no example at all. All eight now give type-specific direction and point atAGENTS.md.draft_*skills said essentially nothing about descriptions. Each now carries a short rule with examples and a pointer toAGENTS.md.Applied to four CLI pages:
agent-conversations.mdxopened with "Learn about" and was the only description over 160 characters.index.mdxhad a strong first sentence followed by one that described the page rather than the product.configuration.mdxsaid you customize the settings file, when you customize the CLI using it.reference.mdxwas a noun fragment rather than a verb-led summary of what you can look up.The other five were already direct and were left alone. All nine now pass one sentence, 50-160 characters, no filler opener.
Notes for reviewers
Open items not addressed here:
cloud-and-orchestration.mdxandconfiguration.mdxhave no standardmaxWidth, which the linter flags. Both are wide UI strips where default content width is plausibly correct, but worth a look.~/Library/Logs/warp-cli/). The Linux and Windows paths are missing, unlike the settings-file section which covers all three. Left as-is rather than guessing at them.permissions-and-profiles.mdxandagent-conversations.mdxdescribe visual surfaces with none at all. Four are worth adding: the permission card, a conversation transcript, the start screen, and the slash command menu. Every candidate needs an authenticated CLI session, which is why none are in this PR.Validation
npm run buildpasses: 364 pages, no new warnings.cli/; no new violations introduced.Co-Authored-By: Oz oz-agent@warp.dev