Explicitly set exporter to none#81
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change,
metrics.enabled=falsedid not set OTEL_METRICS_EXPORTER in the worker pod. An unset exporter causes the OpenTelemetry package default to OTLP, so workers with metrics disabled still attempted to send metrics to the default local collector endpoint. Because no collector is running in the pod, customers saw repeated errors in their work pods such as:failed to upload metrics: Post "https://localhost:4318/v1/metrics": dial tcp [::1]:4318: connect: connection refusedThis change makes the disabled Helm default explicit by setting
OTEL_METRICS_EXPORTER=none, preventing unintended metric export attempts and eliminating the misleading log noise.Verified before and after in a kind cluster.