Skip to content

Reuse existing review requests#474

Draft
vkodithala wants to merge 1 commit into
mainfrom
warp1/app-4655-reuse-existing-reviewers
Draft

Reuse existing review requests#474
vkodithala wants to merge 1 commit into
mainfrom
warp1/app-4655-reuse-existing-reviewers

Conversation

@vkodithala
Copy link
Copy Markdown
Contributor

What

Prefer an existing requested reviewer or team when applying a successful non-member /oz-review result.

Why

Repeated review runs should re-request the same pending reviewer instead of sampling another owner from ownership areas.

Linear: https://linear.app/warpdotdev/issue/APP-4655/reuse-existing-reviewers-for-oz-for-oss-review-requests
Public issue: #473

How

  • Check requested_reviewers and requested_teams before assignee and ownership fallback selection.
  • Reuse the existing reviewer/team through the existing review-request path.

Verification

  • /tmp/oz-for-oss-venv/bin/python -m unittest tests/test_review_pr_reviewer_sampling.py
  • /tmp/oz-for-oss-venv/bin/python -m py_compile core/workflows/review_pr.py tests/test_review_pr_reviewer_sampling.py

Conversation: https://staging.warp.dev/conversation/88e26142-7074-4987-a3ad-d1d03aecc7d2
Run: https://oz.staging.warp.dev/runs/019e8eac-a7f0-73f7-ab11-490077f67dc2

This PR was generated with Oz.

Prefer an existing requested reviewer or team before falling back to PR assignees or ownership-based reviewer selection for non-member approve reviews.

Co-Authored-By: Oz <oz-agent@warp.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant