Include prompts in terminal block copy

[gabrimatic]

Description

• Updates the terminal block Copy action to preserve the existing command + output behavior when the block uses Warp's built-in prompt.
• Includes the shell prompt and right prompt when the copied block was captured with a custom PS1 prompt.
• Reuses the block model's grid ordering for PS1 blocks so prompt, command, right prompt, and output stay in block-selection order.
• Adds regression coverage for both prompt modes, including integration coverage through the block context-menu Copy action.

Linked Issue

• Fixes [Regression] Three-dots → Copy excludes terminal prompt line from block #9123
• The linked issue is labeled ready-to-implement.
• Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Screenshots / Videos

Linux/Xvfb renderer recordings from the integration copy flow:

Warp prompt (HonorPS1=false):

Short video: pr10181-warp-prompt-copy.mp4

PS1 prompt (HonorPS1=true):

Short video: pr10181-ps1-copy.mp4

Testing

• cargo fmt --check
• git diff --check
• cargo nextest run -p warp test_command_and_output_to_string
• WARP_SHELL_PATH=/bin/zsh cargo run -p integration -- test_copy_block_command_and_output_honor_ps1_disabled
• WARP_SHELL_PATH=/bin/zsh cargo run -p integration -- test_copy_block_command_and_output_honor_ps1_enabled
• WARP_SHELL_PATH=/bin/zsh cargo test -p integration test_copy_block_command_and_output -- --nocapture
• Linux/Xvfb renderer recording: WARP_INTEGRATION_TEST_VIDEO=1 WGPU_BACKEND=vulkan WARPUI_USE_REAL_DISPLAY_IN_INTEGRATION_TESTS=1 WARP_SHELL_PATH=/bin/zsh cargo test -p integration test_copy_block_command_and_output -- --nocapture --test-threads=1

[oz-for-oss]

@gabrimatic

I'm starting a first review of this pull request.

I reviewed this pull request and requested human review from: @warpdotdev/oss-maintainers.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR changes the block copy path to serialize the full block via the block model's grid ordering, so prompts, commands, right prompts, and output are copied consistently with block selection behavior.

Concerns

• No blocking correctness, security, or error-handling concerns found in the annotated diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[lucieleblanc]

Hi @gabrimatic, thank you for the PR!

The "copy" action hasn't included the shell prompt or right prompt since March 2022; this isn't a regression. That said, we did recently migrate settings to a file, which may have inadvertently switched your shell prompt back from a custom PS1 to Warp's built-in prompt. Could switching back to PS1 be what you're looking for?

Otherwise, I'd prefer to gate this change on the user's prompt selection; if the user is using a custom PS1, including their prompt in the "copy" action seems reasonable. Otherwise, if they're using the built-in prompt, we should preserve the existing behavior and only include the command + output in the "copy" action.

Please do include a screen recording to demonstrate you've tested this feature locally!

[gabrimatic]

Hi @lucieleblanc, thanks for the review. I updated this to gate the behavior on the block prompt mode:

• built-in Warp prompt: Copy keeps the existing command + output behavior
• custom PS1 prompt: Copy includes the shell prompt, right prompt, command, and output

I also added focused coverage for both prompt modes and re-ran:

• cargo fmt --check
• cargo nextest run -p warp test_command_and_output_to_string
• cargo nextest run -p warp test_copy_blocks

I still need to add the short local screen recording you asked for; I will follow up with that separately.

[gabrimatic]

@lucieleblanc follow-up from the local built app at 44b53cf.

I verified the copy behavior in both prompt modes. The clipboard contents were:

Built-in Warp prompt:

printf 'WARP_PROMPT_OUTPUT\n'
WARP_PROMPT_OUTPUT

Shell prompt / PS1:

soroush@Mini ~ % printf 'PS1_NEW_TAB_OUTPUT\n'
PS1_NEW_TAB_OUTPUT

I also checked the prompt-switch path: after switching to PS1, the next PS1-captured block includes the shell prompt as expected, while an already-started block keeps the previous block prompt mode. That matches this patch using each block's honor_ps1 value.

I am not calling this ready for re-review yet because the requested screen recording is still not attached. I will add that separately once I can capture it cleanly.

[gabrimatic]

@lucieleblanc I pushed one more commit (d3dd1ef) with integration coverage for the exact block Copy path in both prompt modes:

• built-in Warp prompt: context-menu Copy asserts clipboard is command + output
• Shell prompt / PS1: context-menu Copy asserts clipboard is prompt + command + output

I ran:

• WARP_SHELL_PATH=/bin/zsh cargo run -p integration -- test_copy_block_command_and_output_honor_ps1_disabled
• WARP_SHELL_PATH=/bin/zsh cargo run -p integration -- test_copy_block_command_and_output_honor_ps1_enabled
• WARP_SHELL_PATH=/bin/zsh cargo test -p integration test_copy_block_command_and_output -- --nocapture

This is in addition to the focused model tests. The requested screen recording is still pending, so I am leaving the PR marked as not ready for re-review until that is attached.

[gabrimatic]

@lucieleblanc I added the requested visual evidence to the PR body.

Warp prompt (HonorPS1=false):

• Video: https://raw.githubusercontent.com/gabrimatic/warp/pr-10181-linux-evidence/evidence/pr-10181/pr10181-warp-prompt-copy.mp4
• Frame: https://raw.githubusercontent.com/gabrimatic/warp/pr-10181-linux-evidence/evidence/pr-10181/pr10181-warp-prompt-copy-frame.png

PS1 prompt (HonorPS1=true):

• Video: https://raw.githubusercontent.com/gabrimatic/warp/pr-10181-linux-evidence/evidence/pr-10181/pr10181-ps1-copy.mp4
• Frame: https://raw.githubusercontent.com/gabrimatic/warp/pr-10181-linux-evidence/evidence/pr-10181/pr10181-ps1-copy-frame.png

These were captured from the Linux/Xvfb renderer-recorded integration run at d3dd1ef. The run exercises the block context-menu Copy action in both modes and passed:

• built-in Warp prompt: Copy asserts clipboard is command + output
• shell prompt / PS1: Copy asserts clipboard is prompt + command + output
• WARP_INTEGRATION_TEST_VIDEO=1 WGPU_BACKEND=vulkan WARPUI_USE_REAL_DISPLAY_IN_INTEGRATION_TESTS=1 WARP_SHELL_PATH=/bin/zsh cargo test -p integration test_copy_block_command_and_output -- --nocapture --test-threads=1 passed 2/2

Ready for re-review.

[gabrimatic]

/oz-review

[oz-for-oss]

@gabrimatic

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @warpdotdev/oss-maintainers.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR updates the block context-menu Copy action so custom PS1 blocks copy prompt, command, right prompt, and output in the block model's grid order while preserving the existing command-plus-output behavior for Warp's built-in prompt. The added unit and integration coverage exercises both prompt modes through the model helper and UI copy flow.

Concerns

• None.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[github-actions]

Hi @gabrimatic — a reviewer requested changes on this PR and it hasn't had activity from you in 25 days. When you get a chance, please push updates or reply to the review so a reviewer can take another look. Without activity, this PR will be automatically closed after 30 days of inactivity.

[github-actions]

Hi @gabrimatic — final reminder: a reviewer requested changes on this PR and it has been inactive for 26 days. It will be automatically closed in about 4 day(s) unless you push updates or reply. Maintainers can apply the no-autoclose label to keep it open.