Skip to content

Fix Nix build features#12070

Merged
bnavetta merged 1 commit into
warpdotdev:masterfrom
bet4it:fix-nix-build-features
Jun 3, 2026
Merged

Fix Nix build features#12070
bnavetta merged 1 commit into
warpdotdev:masterfrom
bet4it:fix-nix-build-features

Conversation

@bet4it
Copy link
Copy Markdown
Contributor

@bet4it bet4it commented Jun 2, 2026

Description

Remove the stale nld_improvements Cargo feature from the Nix package build.

nld_improvements was removed in #10671, but the flake still passed it through buildFeatures. That causes nix run .#warp-terminal-experimental to fail during Cargo feature validation.

Closes #10979.

Linked Issue

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

  • I have manually tested my changes locally with ./script/run

    Validated locally with nix run .#warp-terminal-experimental

Screenshots / Videos

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

@cla-bot cla-bot Bot added the cla-signed label Jun 2, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Jun 2, 2026

@bet4it

Every PR must be linked to a same-repo issue before Oz can review it.

Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

oz-for-oss[bot]
oz-for-oss Bot previously requested changes Jun 2, 2026
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bet4it

Every PR must be linked to a same-repo issue before Oz can review it.

Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label Jun 2, 2026
@bet4it
Copy link
Copy Markdown
Contributor Author

bet4it commented Jun 2, 2026

/oz-review

@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Jun 2, 2026

@bet4it

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @alokedesai.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot dismissed their stale review June 2, 2026 14:50

Oz no longer requests changes for this pull request after the latest automated review.

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR removes the stale nld_improvements feature from the Nix package build feature list so warp-terminal-experimental no longer passes an unknown Cargo feature.

Concerns

  • No blocking correctness, security, or spec-drift concerns found in the attached diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot requested a review from alokedesai June 2, 2026 14:50
@alokedesai alokedesai requested review from bnavetta and removed request for alokedesai June 2, 2026 15:25
@alokedesai
Copy link
Copy Markdown
Member

@bnavetta Mind taking a look in lieu of me?

Copy link
Copy Markdown
Contributor

@bnavetta bnavetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#11103 is a longer-term fix for this category of issue, but approving this to unblock Nix builds in the meantime - I'd like to take another close pass over that one

@bnavetta bnavetta merged commit 4ca690b into warpdotdev:master Jun 3, 2026
36 checks passed
@bet4it bet4it deleted the fix-nix-build-features branch June 3, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to install warp through nix flake

3 participants