Fix Nix build features#12070
Conversation
|
Every PR must be linked to a same-repo issue before Oz can review it. Next step: open or find a same-repo issue describing this change, then link it to this PR by adding See the contribution guidelines for the full readiness model. Powered by Oz |
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /oz-review to re-trigger review.
See the contribution guidelines for the full readiness model.
Powered by Oz
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
Oz no longer requests changes for this pull request after the latest automated review.
There was a problem hiding this comment.
Overview
This PR removes the stale nld_improvements feature from the Nix package build feature list so warp-terminal-experimental no longer passes an unknown Cargo feature.
Concerns
- No blocking correctness, security, or spec-drift concerns found in the attached diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
@bnavetta Mind taking a look in lieu of me? |
Description
Remove the stale
nld_improvementsCargo feature from the Nix package build.nld_improvementswas removed in #10671, but the flake still passed it throughbuildFeatures. That causesnix run .#warp-terminal-experimentalto fail during Cargo feature validation.Closes #10979.
Linked Issue
ready-to-specorready-to-implement.Testing
I have manually tested my changes locally with
./script/runValidated locally with
nix run .#warp-terminal-experimentalScreenshots / Videos
Agent Mode