Open
Conversation
Contributor
|
Developer build links: Sys11 (Tiny) WPC EM WhiteStar DataEast |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a game_num field to game status reports and adjusts when gameCounter increments so origin messages can include a stable per-game identifier, alongside version bumps for WPC/Data East/common.
Changes:
- Add
game_numtogame_report()payloads (common/WPC/Data East). - Move
S.gameCounterincrement from “game start” to “end of game” in multiple score-tracking paths (including formats). - Bump firmware/version strings (WPC, Data East, common
VectorVersion).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/common/GameStatus.py | Adds game_num to the common game status report payload. |
| src/wpc/GameStatus.py | Adds game_num to the WPC game status report payload. |
| src/data_east/GameStatus.py | Adds game_num to the Data East game status report payload. |
| src/common/ScoreTrack.py | Moves gameCounter increment to end-of-game and shifts origin end-of-game push call site. |
| src/wpc/ScoreTrack.py | Moves gameCounter increment to end-of-game for WPC flow. |
| src/data_east/ScoreTrack.py | Moves gameCounter increment to end-of-game for Data East flow. |
| src/common/Formats.py | Moves gameCounter increment to end-of-game for formats flow. |
| src/common/SharedState.py | Bumps VectorVersion. |
| src/wpc/systemConfig.py | Bumps WPC SystemVersion. |
| src/data_east/systemConfig.py | Bumps Data East SystemVersion. |
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+81
to
86
| #from origin import push_end_of_game | ||
| #push_game_count = 1 | ||
| #last_pushed_game = game | ||
| #push_end_of_game(last_pushed_game, push_game_count) | ||
|
|
||
|
|
| # put ip address back up on system 9 displays | ||
| displayMessage.refresh_9() | ||
|
|
||
| S.gameCounter = (S.gameCounter + 1) % 100 |
| else: | ||
| initials_capture_this_game = False | ||
| S.gameCounter = (S.gameCounter + 1) % 100 | ||
| #S.gameCounter = (S.gameCounter + 1) % 100 |
Comment on lines
+353
to
+354
| #S.gameCounter = (S.gameCounter + 1) % 100 | ||
| #print(f"SCORE: New game counter = {S.gameCounter}") |
| if DataMapper.get_game_active() is True: #game started | ||
| game_state=1 | ||
| S.gameCounter = (S.gameCounter + 1) % 100 | ||
| #S.gameCounter = (S.gameCounter + 1) % 100 |
| @@ -1,4 +1,4 @@ | |||
| VectorVersion = "1.11.10" | |||
| VectorVersion = "1.11.11" | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Motivation and Context
Testing
Screenshots (if applicable)
Types of Changes
Checklist
Additional Notes