Refactor cross-correlation functions to remove pretilt search range#135
Merged
Conversation
Removed pretilt_search_range parameter and related code from cross-correlation functions. Updated function calls and documentation accordingly.
The previous commit swapped the import to tiltxcorr but left the call site referencing the old tiltxcorr_with_sample_tilt_estimation name, causing a NameError whenever cross-correlation alignment ran. Also removes now-stale references to pretilt estimation in docstrings and CLI help text. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
torch-projectors is now published on PyPI, so the custom GitHub Pages index URL is no longer needed for the CPU CI wheel. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed pretilt_search_range parameter and related code from cross-correlation functions. Updated function calls and documentation accordingly.
The auto_zero command in WarpTools is much more reliable at finding pre-tilt, so I thought we should just remove it here. If the tilt axis angle is known and the pre-tilt corrected, this xcorr function is really good at getting initial alignments.