fix: map MCP field names to Tweek API format for task operations#4
Open
gabdorf wants to merge 2 commits intowaspeer:mainfrom
Open
fix: map MCP field names to Tweek API format for task operations#4gabdorf wants to merge 2 commits intowaspeer:mainfrom
gabdorf wants to merge 2 commits intowaspeer:mainfrom
Conversation
Add mapCreateTaskToApi() and mapTaskPatchToApi() functions to properly map field names between MCP interface and Tweek API: - title -> text - description -> note - completed -> done Also ensures required API fields (done, gcal) are set for task creation. Part of fix for waspeer#2
Use mapCreateTaskToApi() and mapTaskPatchToApi() to properly translate MCP field names to Tweek API format before sending requests. Closes waspeer#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Task creation and updates were failing because the MCP interface uses different field names than the Tweek API expects. This PR adds mapper functions to translate between the two formats.
Field Name Mappings
titletextdescriptionnotecompleteddoneChanges
src/tweek/mappers.tsmapCreateTaskToApi()function to mapCreateTaskRequestto API formatmapTaskPatchToApi()function to mapTaskPatchto API formatcompleted→done)mapCreateTaskToApi()sets required API fields:done(default: false),gcal(false)src/tweek/tweekClient.tscreateTask()to usemapCreateTaskToApi()before sending dataupdateTask()to usemapTaskPatchToApi()before sending dataCloses #2