Fix model re-downloading on every launch#54
Closed
rgkirch wants to merge 1 commit intowatzon:mainfrom
Closed
Conversation
TranscriptionService has its own KMPTranscriptionRuntimeBridge instance separate from ModelManager's. Its internal Kotlin runtime keeps an installedModels list that starts empty and was never refreshed before loadModel() was called. The runtime would always respond MODEL_NOT_INSTALLED, triggering attemptWhisperModelRepairAndReload which deletes and re-downloads the model on every launch. Fix by refreshing the installed model index before each load. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
Thanks for tracking this down. I’m going to close this PR because we’re rolling the app back to a single mac-native architecture, and this fix targets the Kotlin runtime bridge path that is being removed.\n\nThe symptom made sense on the KMP branch, but it won’t be part of the codebase once the rollback lands. |
Author
|
Thanks for following up. GLHF I have a diy script that’s working well for me now so. So long and have fun! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning: This code is all claude. It works for me though. Feel free to reject it if you don't like low effort contributions. The weird thing about this is that I only have the issue when I build the app locally so; Idk what the actual bug is but it went away with this change. Probably definitely reject this pr. Idk.
TranscriptionService has its own KMPTranscriptionRuntimeBridge instance separate from ModelManager's. Its internal Kotlin runtime keeps an installedModels list that starts empty and was never refreshed before loadModel() was called. The runtime would always respond MODEL_NOT_INSTALLED, triggering attemptWhisperModelRepairAndReload which deletes and re-downloads the model on every launch.
Fix by refreshing the installed model index before each load.