chore(deps): update dependency go to 1.26 - #26
Conversation
|
PR author is in the excluded authors list. |
|
🌊 WAVE BugBot — 2 finding(s)🔴 2
severity: critical · major · minor · info — local review · $0 inference · wave-dispatch · react 👍/👎 to tune |
f42393f to
e70001c
Compare
d0b88c9 to
4317fdc
Compare
Review flagged that a change raising what consumers need in order to build the published SDK shipped with no Unreleased entry. Correct, and the same miss I made on the sibling public repo in the same batch. The entry states the breaking part plainly (older or pinned toolchains, and GOTOOLCHAIN=off, hard-fail), the escape hatch (GOTOOLCHAIN=auto handles it), why 1.25 and not 1.26 (oldest release still receiving security fixes, widest supported consumer window), and that nothing downstream needs more - after the bump the highest go requirement in the whole module graph is this module itself. It also records the distinction that makes this PR separate from #26: setup-go installed 1.22.12 and the toolchain switched itself UP to 1.24.0 off this directive, so the workflow pin was never the operative version. A floor that ships inside go.mod cannot be fixed by a workflow change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
4317fdc to
031ea8d
Compare
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: "1.22" | ||
| go-version: "1.26" |
There was a problem hiding this comment.
🔍 Dependency caching disabled with an outdated justification
The cache: false comment claims the module is stdlib-only with no go.sum to cache, but sdk-go/go.mod now requires github.com/ethereum/go-ethereum v1.17.3 plus a dozen indirect deps and sdk-go/go.sum exists. Disabling the module cache means every CI run re-downloads those (including heavy crypto deps like supranational/blst), which slows the gate and adds proxy-flakiness risk. Since this PR is already touching the Go toolchain config here, enabling caching (and dropping the stale comment) would be a natural follow-up.
Was this helpful? React with 👍 or 👎 to provide feedback.
ApprovabilityVerdict: Needs human review This PR bumps Go version from 1.22 to 1.26 in CI workflows - a low-risk change. However, both modified files are owned by wave-av/sdk-owners, and Renovate is not a designated owner, so review by the code owners is appropriate. You can customize Macroscope's approvability policy. Learn more. |
This PR contains the following updates:
1.22→1.26Release Notes
actions/go-versions (go)
v1.26.6: 1.26.6Compare Source
Go 1.26.6
v1.26.5: 1.26.5Compare Source
Go 1.26.5
v1.26.4: 1.26.4Compare Source
Go 1.26.4
v1.26.3: 1.26.3Compare Source
Go 1.26.3
v1.26.2: 1.26.2Compare Source
Go 1.26.2
v1.26.1: 1.26.1Compare Source
Go 1.26.1
v1.26.0: 1.26.0Compare Source
Go 1.26.0
v1.25.13: 1.25.13Compare Source
Go 1.25.13
v1.25.12: 1.25.12Compare Source
Go 1.25.12
v1.25.11: 1.25.11Compare Source
Go 1.25.11
v1.25.10: 1.25.10Compare Source
Go 1.25.10
v1.25.9: 1.25.9Compare Source
Go 1.25.9
v1.25.8: 1.25.8Compare Source
Go 1.25.8
v1.25.7: 1.25.7Compare Source
Go 1.25.7
v1.25.6: 1.25.6Compare Source
Go 1.25.6
v1.25.5: 1.25.5Compare Source
Go 1.25.5
v1.25.4: 1.25.4Compare Source
Go 1.25.4
v1.25.3: 1.25.3Compare Source
Go 1.25.3
v1.25.2: 1.25.2Compare Source
Go 1.25.2
v1.25.1: 1.25.1Compare Source
Go 1.25.1
v1.25.0: 1.25.0Compare Source
Go 1.25.0
v1.24.13: 1.24.13Compare Source
Go 1.24.13
v1.24.12: 1.24.12Compare Source
Go 1.24.12
v1.24.11: 1.24.11Compare Source
Go 1.24.11
v1.24.10: 1.24.10Compare Source
Go 1.24.10
v1.24.9: 1.24.9Compare Source
Go 1.24.9
v1.24.8: 1.24.8Compare Source
Go 1.24.8
v1.24.7: 1.24.7Compare Source
Go 1.24.7
v1.24.6: 1.24.6Compare Source
Go 1.24.6
v1.24.5: 1.24.5Compare Source
Go 1.24.5
v1.24.4: 1.24.4Compare Source
Go 1.24.4
v1.24.3: 1.24.3Compare Source
Go 1.24.3
v1.24.2: 1.24.2Compare Source
Go 1.24.2
v1.24.1: 1.24.1Compare Source
Go 1.24.1
v1.24.0: 1.24.0Compare Source
Go 1.24.0
v1.23.12: 1.23.12Compare Source
Go 1.23.12
v1.23.11: 1.23.11Compare Source
Go 1.23.11
v1.23.10: 1.23.10Compare Source
Go 1.23.10
v1.23.9: 1.23.9Compare Source
Go 1.23.9
v1.23.8: 1.23.8Compare Source
Go 1.23.8
v1.23.7: 1.23.7Compare Source
Go 1.23.7
v1.23.6: 1.23.6Compare Source
Go 1.23.6
v1.23.5: 1.23.5Compare Source
Go 1.23.5
v1.23.4: 1.23.4Compare Source
Go 1.23.4
v1.23.3: 1.23.3Compare Source
Go 1.23.3
v1.23.2: 1.23.2Compare Source
Go 1.23.2
v1.23.1: 1.23.1Compare Source
Go 1.23.1
v1.23.0: 1.23.0Compare Source
Go 1.23.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.