Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
persist-credentials: false
- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with:
python-version: "3.12"
python-version: "3.14"
- run: pip install pyyaml
Comment on lines +59 to 60

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Reusable workflow bumped here may drift from its upstream mirror

This file's header comment states it mirrors wave-foundation/scripts/validate-skills.py / the shared checks.yml and instructs keeping the two in sync. Bumping the interpreter only here introduces drift with the upstream copy that other WAVE repos consume; the same bump likely needs to land in wave-foundation. Also note the inlined gate does pip install pyyaml on the pinned interpreter — verify a PyYAML wheel exists for 3.14 in CI, otherwise the skill gate falls back to a source build and can fail.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

- name: Skill frontmatter gate
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: "3.12"
python-version: "3.14"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Python matrix and package metadata still cap at 3.12

The dependency bump moves the CI toolchain workflows to Python 3.14, but the actual test matrix in .github/workflows/test-python.yml:27 still only exercises 3.10 and 3.12, and sdk-python/pyproject.toml classifiers / [tool.black] target-version stop at 3.12 (with requires-python = ">=3.10"). So the wheel is now built on an interpreter that is never tested against, and the published metadata does not advertise 3.13/3.14 support. Worth deciding whether the matrix and classifiers should be extended alongside this bump.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

- name: Build sdist + wheel
run: python -m pip install --upgrade build && python -m build
- name: Validate metadata (twine check)
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/registry-parity.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
node-version: "22"
- uses: actions/setup-python@v5
with:
python-version: "3.11"
python-version: "3.14"
- name: Per-package declared vs npm-latest
run: |
set -uo pipefail
Expand Down
Loading