chore(deps): update dependency ruby to v3.4.10 - #29
Conversation
|
PR author is in the excluded authors list. |
|
c5f7934 to
f3197df
Compare
a8ea997 to
5234e3e
Compare
c38eee3 to
48c8701
Compare
🌊 WAVE BugBot — 2 finding(s)🔴 2
severity: critical · major · minor · info — local review · $0 inference · wave-dispatch · react 👍/👎 to tune |
48c8701 to
b784812
Compare
| - uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: "3.3" | ||
| ruby-version: "3.4.10" |
There was a problem hiding this comment.
🔍 Exact patch pin diverges from the test matrix and the gem's supported range
The publish workflow now pins an exact patch release (3.4.10) for both the verify and publish jobs, while .github/workflows/test-ruby.yml:27 still tests on ["3.1", "3.3"] and sdk-ruby/wave-sdk.gemspec declares required_ruby_version = ">= 3.0". Consequences worth confirming: (1) the build/verify step in the release path no longer matches any version actually exercised by CI, so a release could be built on a toolchain that was never tested; (2) an exact patch pin needs a matching ruby/setup-ruby prebuilt binary — if that exact patch is unavailable on the runner image, the release job fails hard, whereas a 3.4 (minor) pin would keep resolving. Consider pinning "3.4" here and/or adding 3.4 to the test matrix so publish and test toolchains stay aligned.
Was this helpful? React with 👍 or 👎 to provide feedback.
ApprovabilityVerdict: Needs human review This dependency update changes the Ruby version in the publish workflow, but the author (Renovate) doesn't own the modified file (owned by wave-av/sdk-owners). Additionally, there's an unresolved comment noting that the exact patch pin (3.4.10) diverges from the test matrix, potentially causing releases to be built on an untested toolchain. You can customize Macroscope's approvability policy. Learn more. |
This PR contains the following updates:
3.3→3.4.10Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.