Skip to content

chore(deps): update dependency ruby to v3.4.10 - #29

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/ruby-3.x
Open

chore(deps): update dependency ruby to v3.4.10#29
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/ruby-3.x

Conversation

@renovate

@renovate renovate Bot commented Jun 27, 2026

Copy link
Copy Markdown

This PR contains the following updates:

Package Type Update Change
ruby (source) uses-with minor 3.33.4.10

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.


Open in Devin Review

@greptile-apps

greptile-apps Bot commented Jun 27, 2026

Copy link
Copy Markdown

PR author is in the excluded authors list.

@changeset-bot

changeset-bot Bot commented Jun 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 48c8701

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renovate
renovate Bot force-pushed the renovate/ruby-3.x branch from c5f7934 to f3197df Compare July 3, 2026 00:05
@renovate renovate Bot changed the title chore(deps): update dependency ruby to v3.4.9 chore(deps): update dependency ruby to v3.4.10 Jul 3, 2026
@renovate
renovate Bot force-pushed the renovate/ruby-3.x branch 4 times, most recently from a8ea997 to 5234e3e Compare July 22, 2026 05:14
@renovate
renovate Bot force-pushed the renovate/ruby-3.x branch 2 times, most recently from c38eee3 to 48c8701 Compare August 1, 2026 03:53
@wave-bugbot

wave-bugbot Bot commented Aug 12, 2026

Copy link
Copy Markdown

🌊 WAVE BugBot — 2 finding(s)

🔴 2

  • 🔴 P0 .github/workflows/publish-rubygems.yml:31 CWE-312Hardcoded chain/mainnet config on a money path
    The workflow specifies the Ruby version directly in the action, which can lead to issues if the version is not correctly managed or updated.
  • 🔴 P0 .github/workflows/publish-rubygems.yml:54 CWE-312Hardcoded chain/mainnet config on a money path
    The workflow specifies the Ruby version directly in the action, which can lead to issues if the version is not correctly managed or updated.

severity: critical · major · minor · info — local review · $0 inference · wave-dispatch · react 👍/👎 to tune

@renovate
renovate Bot force-pushed the renovate/ruby-3.x branch from 48c8701 to b784812 Compare August 14, 2026 17:25

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

- uses: ruby/setup-ruby@v1
with:
ruby-version: "3.3"
ruby-version: "3.4.10"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Exact patch pin diverges from the test matrix and the gem's supported range

The publish workflow now pins an exact patch release (3.4.10) for both the verify and publish jobs, while .github/workflows/test-ruby.yml:27 still tests on ["3.1", "3.3"] and sdk-ruby/wave-sdk.gemspec declares required_ruby_version = ">= 3.0". Consequences worth confirming: (1) the build/verify step in the release path no longer matches any version actually exercised by CI, so a release could be built on a toolchain that was never tested; (2) an exact patch pin needs a matching ruby/setup-ruby prebuilt binary — if that exact patch is unavailable on the runner image, the release job fails hard, whereas a 3.4 (minor) pin would keep resolving. Consider pinning "3.4" here and/or adding 3.4 to the test matrix so publish and test toolchains stay aligned.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@macroscopeapp

macroscopeapp Bot commented Aug 14, 2026

Copy link
Copy Markdown

Approvability

Verdict: Needs human review

This dependency update changes the Ruby version in the publish workflow, but the author (Renovate) doesn't own the modified file (owned by wave-av/sdk-owners). Additionally, there's an unresolved comment noting that the exact patch pin (3.4.10) diverges from the test matrix, potentially causing releases to be built on an untested toolchain.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants