chore(deps): update actions/checkout action to v7 - #32
Conversation
|
PR author is in the excluded authors list. |
|
a6af343 to
f928afd
Compare
aa647bd to
53d9d4c
Compare
🌊 WAVE BugBot — 5 finding(s)🔴 3 · 🟠 2
severity: critical · major · minor · info — local review · $0 inference · wave-dispatch · react 👍/👎 to tune |
53d9d4c to
7b6be07
Compare
| working-directory: sdk-typescript | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 |
There was a problem hiding this comment.
🔍 Mixed pinning styles for the same action version across workflows
The repo pins actions/checkout two different ways: by commit SHA with a version comment in .github/workflows/_checks.yml:23,54,114 and .github/workflows/public-repo-guard.yml:45, but by floating major tag (@v7) in the ten publish/test/release workflows (e.g. .github/workflows/publish-npm.yml:30, .github/workflows/test-go.yml:31). The bump keeps that inconsistency. Both SHA sites now use the same commit (3d3c42e…) with the same # v7.0.1 comment, so they are internally consistent, but the tag-pinned workflows — including the ones with publish privileges and id-token: write — remain mutable references. Worth deciding on one convention, especially for the release lanes.
Was this helpful? React with 👍 or 👎 to provide feedback.
| timeout-minutes: 10 | ||
| steps: | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1 | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 |
There was a problem hiding this comment.
🔍 _checks.yml is documented as a mirror of a shared upstream workflow
The header of this file states it is the reusable cross-project gate that other WAVE repos consume via wave-av/wave-foundation/.github/workflows/checks.yml@master and that it must stay in sync with wave-foundation/scripts/validate-skills.py. Bumping the checkout pin only here introduces drift from the upstream copy; the same bump should be landed in wave-foundation (or this file re-synced) so consumers don't diverge.
Was this helpful? React with 👍 or 👎 to provide feedback.
| working-directory: sdk-typescript | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 |
There was a problem hiding this comment.
🟨 Most workflows pin actions/checkout to a mutable tag instead of a commit SHA
The bump moves actions/checkout to @v7 in the publish/test workflows (e.g. .github/workflows/publish-npm.yml:30, .github/workflows/publish-crates.yml:31,51, .github/workflows/publish-rubygems.yml:28,49, .github/workflows/publish-pypi.yml:28, .github/workflows/release-go.yml:22, .github/workflows/registry-parity.yml:27, .github/workflows/test-*.yml), while the security gates in .github/workflows/_checks.yml and .github/workflows/public-repo-guard.yml use a full commit SHA. A floating major tag is mutable, so a compromised or force-moved tag would execute attacker-controlled code in workflows that hold OIDC trusted-publishing rights (id-token: write) and can publish packages to npm/crates.io/RubyGems/PyPI.
Was this helpful? React with 👍 or 👎 to provide feedback.
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1 | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 |
There was a problem hiding this comment.
🟨 Security gate checkout keeps git credentials available to later steps
The checkout step in the public-repo-guard security gate (.github/workflows/public-repo-guard.yml:45) does not set persist-credentials: false, unlike every other checkout in the repo (e.g. .github/workflows/_checks.yml:24-25). The workflow then downloads and executes an external binary (gitleaks) and runs a repo-local shell script in the same job, both of which can read the persisted GITHUB_TOKEN from .git/config.
Was this helpful? React with 👍 or 👎 to provide feedback.
ApprovabilityVerdict: Needs human review Updates You can customize Macroscope's approvability policy. Learn more. |
This PR contains the following updates:
v4→v7v5.0.1→v7.0.1v4.3.1→v7.0.1Release Notes
actions/checkout (actions/checkout)
v7.0.1Compare Source
v7.0.0Compare Source
v7Compare Source
v6.1.0Compare Source
v6.0.3Compare Source
v6.0.2Compare Source
v6.0.1Compare Source
v6.0.0Compare Source
v6Compare Source
v5.1.0Compare Source
v5.0.1Compare Source
v5.0.0Compare Source
v5Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.