fix(deps): sdk 1.30.0 unblocks @hono/node-server 2.x (closes #49) - #50
fix(deps): sdk 1.30.0 unblocks @hono/node-server 2.x (closes #49)#50yakimoto wants to merge 2 commits into
Conversation
closes #49, which called this a major bump needing a breaking-change assessment. that was true against @modelcontextprotocol/sdk 1.29.0, which declared @hono/node-server ^1.19.9. sdk 1.30.0, published 2026-07-27, widened the range to ^1.19.9 || ^2.0.5, so no pnpm.overrides pin is needed. forcing 2.x onto the old sdk would have meant overriding a dependency own declared range, which is the failure claude-workstation#554 documents. @modelcontextprotocol/sdk 1.29.0 -> 1.30.0 @hono/node-server 1.19.14 -> 2.0.12 the one manifest line is deliberate, not the claude-workstation#555 churn. #555 is about all 48 package.json files being reformatted and em dashes unescaped inside published description fields; that was reverted. this run touched one manifest and one line. it is load-bearing: @wave-av/mcp-server is published, and consumers resolve against its declared range rather than our lockfile, so ^1.0.0 would let them pull sdk 1.29.x and the vulnerable node-server straight back in. pnpm install --frozen-lockfile clean, pnpm -r build clean, 143 tests / 52 files / 48 packages green, type-check clean. packages/mcp-server/src/server.ts imports only StdioServerTransport and never builds an HTTP transport, so node-server sits off the exercised path. the identical bump was verified end to end on wave-av/mcp-server#68 by driving the built binary over stdio: initialize plus tools/list returning all 18 tools, matching baseline. CI cannot run.
|
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_7383ed78-198a-429f-83ad-92da8f883030) |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Closes #49.
#49 asked the wrong question, and the answer changed underneath it
I filed #49 saying this needed a breaking-change assessment because
1.19.14 → 2.0.5is a major jump. That framing was correct against SDK 1.29.0, which pinned@hono/node-server: ^1.19.9— the only way through was apnpm.overridesentry forcing 2.x against a dependency's own declared range, which is exactly the trap in claude-workstation#554.@modelcontextprotocol/sdk@1.30.0shipped on 2026-07-27 and widened that range to^1.19.9 || ^2.0.5. So there is no override, no pin, and no breaking-change assessment to make — the SDK maintainers did it. Updating the SDK is the whole fix.@hono/node-serveris not declared by any manifest in this workspace; it arrives solely through the SDK:The one manifest line, and why it stays
"dependencies": { - "@modelcontextprotocol/sdk": "^1.0.0", + "@modelcontextprotocol/sdk": "^1.30.0",This is not the churn from claude-workstation#555. That issue is about
pnpm update --recursive --lockfile-onlysilently reformatting all 48package.jsonfiles and unescaping—into literal em-dashes inside publisheddescriptionfields — 928 lines of it, reverted before it could ship. This run touched one manifest and one line.And it's load-bearing.
@wave-av/mcp-serveris published, so downstream consumers resolve against its declared range, not our lockfile. Left at^1.0.0, a consumer could resolve SDK 1.29.x and pull the vulnerable@hono/node-serverright back in.^1.30.0states the requirement that actually exists.Verification
CI can't run — Actions are refusing every job org-wide on an account-level billing lock (
plan=free,locked=yes, confirmed live this morning againstadkanddispatch-edge). All local:pnpm auditcompares version strings and never loads a module, so it can't be the evidence here. Two things stand in for it:packages/mcp-server/src/server.tsimports onlyStdioServerTransportand never constructs an HTTP transport, so@hono/node-serveris in the tree but off the exercised code path.initialize→wave-mcp-server, protocol2025-06-18;tools/list→ 18 tools, byte-identical to baseline.Merge-order note
#48 also rewrites
sdk-typescript/pnpm-lock.yaml. This PR is based onmain@9eb128aand is independent of it, but the two will conflict textually. Whichever lands second should re-run its own update command rather than hand-merging the lockfile — a hand-merged pnpm lockfile is how you get a tree that installs but doesn't match either intent.After #48 and this one, the only alerts left on the repo are
vite×2 andesbuild×1, all dev-only viavitest, which Renovate #24 already bumps.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.Note
Cursor Bugbot is generating a summary for commit 5b956a9. Configure here.
Summary by cubic
Update
@modelcontextprotocol/sdkto^1.30.0so consumers resolve@hono/node-server2.x (>=2.0.5) transitively, clearing the advisory without overrides. Added a Security note to the changelog.@modelcontextprotocol/sdk: 1.29.0 → 1.30.0@hono/node-server: 1.19.14 → 2.0.12Written for commit 12aff7a. Summary will update on new commits.