Skip to content

chore(guard): sync vendored public-repo-guard to canonical #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wave-av-release-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(guard): sync vendored public-repo-guard to canonical #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/public-repo-guard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,15 @@ jobs:
name: Secrets + content policy
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

@devin-ai-integration devin-ai-integration Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Checkout pin bumped only in this workflow; rest of repo still on v4 / floating tags

This is now the only workflow pinned to a v7 commit SHA; .github/workflows/_checks.yml pins v4.3.1 by SHA and ~10 other workflows (e.g. .github/workflows/publish-npm.yml:30, .github/workflows/test-go.yml:31) still use the mutable actions/checkout@v4 tag without persist-credentials: false. If the intent is supply-chain hardening (zizmor artipacked), the same treatment is missing across those workflows, several of which are publish jobs with elevated permissions.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@devin-ai-integration devin-ai-integration Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Pinned commit SHA for v7.0.0 should be verified against upstream

The pin 9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 cannot be validated from the repo contents. Since this workflow is the repository's security gate, confirm the SHA actually corresponds to the actions/checkout v7.0.0 tag upstream — a wrong SHA either fails the job outright or silently runs a different revision than the comment claims.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

with:
# Checkout defaults to persisting the job token for later steps: since v6 it
# lives in a file under $RUNNER_TEMP referenced from .git/config, no longer in
# .git/config itself. It is still a live credential in the job, and this job
# downloads a third-party binary (gitleaks, below) and runs it over the whole
# tree. Nothing here pushes -- the scan is `--no-git` over the working tree --
# so no step needs authenticated Git; drop it. (zizmor: artipacked)
persist-credentials: false

# gitleaks' GitHub Action requires a paid license for organizations; the CLI
# itself is MIT-licensed and free. Pin the version AND verify the release
Expand Down
Loading