chore(observability): drop retired Dash0 from console source enum and AgentLogger comment - #63
chore(observability): drop retired Dash0 from console source enum and AgentLogger comment#63yakimoto wants to merge 4 commits into
Conversation
… AgentLogger comment Dash0 is retired from the WAVE stack (LEV-009 sweep). Two missed references in the sdks repo: - packages/console/src/console.ts: 'dash0' source enum value (unused, single ref) — removed; the console query surface has no Dash0 backend. - packages/adk/src/agents/AgentLogger.ts: comment '(Dash0/Sentry)' -> '(Sentry + OTLP ingest)'. The mcp-server otel-init.ts DASH0_AUTH_TOKEN env contract is NOT changed here — it is a runtime wiring contract with potential consumers; flagged separately (see northstar-fractal).
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_d7e2f352-62da-4150-b254-171b851464cb) |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 14 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
PR Summary by QodoRemove retired Dash0 from console source union and AgentLogger docs
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can enable the Remediation agent and Qodo fixes findings in a dedicated fix PR More tips ↗ | Customize Qodo ↗ | Qodo docs ↗ |
Qodo FixerNo findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR. |
There was a problem hiding this comment.
Risk: low. Left a non-blocking comment because Cursor Bugbot and Cursor Security Agent were present but skipped (Bugbot hit a usage limit), so automated review is incomplete and this is not approved. Human review is needed; no reviewers were assigned because the only identifiable editor is the PR author and the CODEOWNERS team could not be resolved to usernames.
Sent by Cursor Approval Agent: Pull Request Router and Approver
…nion removal in changelog Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
ApprovabilityVerdict: Needs human review Author does not own any changed files (all owned by wave-av/sdk-owners). Unresolved review comment at Medium severity raises concern that edits to generated SDK source will be overwritten by next automated sync. Additional comments note incomplete cleanup of Dash0 references elsewhere. No code changes detected at You can customize Macroscope's approvability policy. Learn more. |
… removed) Addresses review thread: the public type surface changed (dash0 removed from ConsoleSourceResult['source']), so it's called out as breaking under Unreleased.
# Conflicts: # CHANGELOG.md
🌊 WAVE BugBot — 4 finding(s)🔴 3 · 🟠 1
severity: critical · major · minor · info — local review · $0 inference · wave-dispatch · react 👍/👎 to tune |


What
Drops the retired Dash0 vendor from two spots in the sdks repo missed by the earlier sweep (LEV-009):
packages/console/src/console.ts— removed the'dash0'value from theConsoleSourceResult.sourceunion, and dropped Dash0 from the module header's vendor-source list. No backend mapping, not consumed anywhere else.packages/adk/src/agents/AgentLogger.ts— comment(Dash0/Sentry)→(Sentry + OTLP ingest).CHANGELOG.md— logged the union narrowing under[Unreleased](user-facing typed-surface change, per AGENTS.md).Why
Dash0 is retired from the WAVE stack (disabled MCP, orphaned rig config,
legacyin the subprocessor registry). A public SDK surface still exposing'dash0'as a valid console source is a stale vendor claim — any agent reading the type would believe a Dash0 console backend exists.Scope
packages/mcp-server/src/tools/otel-init.ts(DASH0_AUTH_TOKENenv contract) is deliberately untouched — it's a runtime wiring contract with potential consumers; changing env names is a behavioral decision, flagged separately.Carve note
The touched package sources are carved copies of the internal monorepo (
scripts/sync-from-monorepo.sh), so hand edits are normally overwritten on the next sync. This out-of-band edit is intentional: it keeps the published0.0.xpreview surface from advertising a retired vendor now, and the same Dash0 removal must land in the canonical monorepo source (tracked under the LEV-009 sweep) before the next sync so it is not reverted.Verification
rg -in dash0in both changed files → 0.'dash0').Note
Low Risk
Documentation and a narrowed string union with no runtime logic changes; no remaining
'dash0'references in the changed packages beyond deliberately untouched otel-init.Overview
Removes retired Dash0 from two public SDK surfaces so types and docs match the current observability stack (Sentry + OTLP ingest).
In
console.ts,'dash0'is dropped from theConsoleSourceResult.sourceunion so console query results can no longer be typed as a Dash0 backend. InAgentLogger.ts, the file comment is updated from(Dash0/Sentry)to(Sentry + OTLP ingest).No runtime or API behavior changes—only the type union and documentation.
Reviewed by Cursor Bugbot for commit 91237d8. Configure here.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.Note
Drop
dash0fromConsoleSourceResult['source']union and update observability platform referencesRemoves the retired
dash0literal from thesourcediscriminant union in console.ts and updates doc comments in AgentLogger.ts to reflect the current observability stack (Sentry + OTLP ingest). Risk: removingdash0from the exported union is a breaking type change for any consumers checking for that literal.Macroscope summarized 76aa1e1.