Skip to content

chore(observability): drop retired Dash0 from console source enum and AgentLogger comment - #63

Open
yakimoto wants to merge 4 commits into
mainfrom
feat/nsf-dash0-sweep2
Open

chore(observability): drop retired Dash0 from console source enum and AgentLogger comment#63
yakimoto wants to merge 4 commits into
mainfrom
feat/nsf-dash0-sweep2

Conversation

@yakimoto

@yakimoto yakimoto commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

What

Drops the retired Dash0 vendor from two spots in the sdks repo missed by the earlier sweep (LEV-009):

  1. packages/console/src/console.ts — removed the 'dash0' value from the ConsoleSourceResult.source union, and dropped Dash0 from the module header's vendor-source list. No backend mapping, not consumed anywhere else.
  2. packages/adk/src/agents/AgentLogger.ts — comment (Dash0/Sentry)(Sentry + OTLP ingest).
  3. CHANGELOG.md — logged the union narrowing under [Unreleased] (user-facing typed-surface change, per AGENTS.md).

Why

Dash0 is retired from the WAVE stack (disabled MCP, orphaned rig config, legacy in the subprocessor registry). A public SDK surface still exposing 'dash0' as a valid console source is a stale vendor claim — any agent reading the type would believe a Dash0 console backend exists.

Scope

  • Type/comment only, no runtime behavior change.
  • packages/mcp-server/src/tools/otel-init.ts (DASH0_AUTH_TOKEN env contract) is deliberately untouched — it's a runtime wiring contract with potential consumers; changing env names is a behavioral decision, flagged separately.

Carve note

The touched package sources are carved copies of the internal monorepo (scripts/sync-from-monorepo.sh), so hand edits are normally overwritten on the next sync. This out-of-band edit is intentional: it keeps the published 0.0.x preview surface from advertising a retired vendor now, and the same Dash0 removal must land in the canonical monorepo source (tracked under the LEV-009 sweep) before the next sync so it is not reverted.

Verification

  • rg -in dash0 in both changed files → 0.
  • CI type-check will confirm the union removal is safe (no consumers reference 'dash0').

Note

Low Risk
Documentation and a narrowed string union with no runtime logic changes; no remaining 'dash0' references in the changed packages beyond deliberately untouched otel-init.

Overview
Removes retired Dash0 from two public SDK surfaces so types and docs match the current observability stack (Sentry + OTLP ingest).

In console.ts, 'dash0' is dropped from the ConsoleSourceResult.source union so console query results can no longer be typed as a Dash0 backend. In AgentLogger.ts, the file comment is updated from (Dash0/Sentry) to (Sentry + OTLP ingest).

No runtime or API behavior changes—only the type union and documentation.

Reviewed by Cursor Bugbot for commit 91237d8. Configure here.


View with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is enabled.

Review in cubic

Note

Drop dash0 from ConsoleSourceResult['source'] union and update observability platform references

Removes the retired dash0 literal from the source discriminant union in console.ts and updates doc comments in AgentLogger.ts to reflect the current observability stack (Sentry + OTLP ingest). Risk: removing dash0 from the exported union is a breaking type change for any consumers checking for that literal.

Macroscope summarized 76aa1e1.

… AgentLogger comment

Dash0 is retired from the WAVE stack (LEV-009 sweep). Two missed references
in the sdks repo:
- packages/console/src/console.ts: 'dash0' source enum value (unused,
  single ref) — removed; the console query surface has no Dash0 backend.
- packages/adk/src/agents/AgentLogger.ts: comment '(Dash0/Sentry)' ->
  '(Sentry + OTLP ingest)'.

The mcp-server otel-init.ts DASH0_AUTH_TOKEN env contract is NOT changed
here — it is a runtime wiring contract with potential consumers; flagged
separately (see northstar-fractal).
@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_d7e2f352-62da-4150-b254-171b851464cb)

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 14 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 72be9518-37c7-4377-a1c9-5d106e3d3e6b

📥 Commits

Reviewing files that changed from the base of the PR and between bae994f and 76aa1e1.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • sdk-typescript/packages/adk/src/agents/AgentLogger.ts
  • sdk-typescript/packages/console/src/console.ts

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Remove retired Dash0 from console source union and AgentLogger docs

🐞 Bug fix 📝 Documentation 🕐 Less than 10 minutes

Grey Divider

AI Description

• Remove retired "dash0" value from the public console source union type.
• Update AgentLogger docstring to reflect current observability path (Sentry + OTLP ingest).
Diagram

graph TD
  A["SDK Consumers"] --> B["console.ts"] --> C(("ConsoleSourceResult.source"))
  D["WAVE Agents"] --> E["AgentLogger.ts"] --> F(("Logger docs"))
Loading
High-Level Assessment

Current approach is the right one: remove the stale 'dash0' literal from the exported union so downstream consumers can’t mistakenly assume a Dash0-backed console exists, and align documentation with the actual observability path. Any alternative (e.g., deprecating instead of removing) would add maintenance overhead without a corresponding supported backend.

Files changed (2) +1 / -2

Bug fix (1) +0 / -1
console.tsDrop 'dash0' from ConsoleSourceResult.source union +0/-1

Drop 'dash0' from ConsoleSourceResult.source union

• Removes the 'dash0' literal from the ConsoleSourceResult.source union type to avoid advertising a retired/unsupported console backend. This is a compile-time surface change only.

sdk-typescript/packages/console/src/console.ts

Documentation (1) +1 / -1
AgentLogger.tsUpdate AgentLogger docstring to remove Dash0 reference +1/-1

Update AgentLogger docstring to remove Dash0 reference

• Rewords the top-level comment to describe forwarding to Sentry + OTLP ingest instead of Dash0/Sentry. No type or runtime behavior changes.

sdk-typescript/packages/adk/src/agents/AgentLogger.ts

devin-ai-integration[bot]

This comment was marked as resolved.

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can enable the Remediation agent and Qodo fixes findings in a dedicated fix PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

Qodo Fixer

No findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low. Left a non-blocking comment because Cursor Bugbot and Cursor Security Agent were present but skipped (Bugbot hit a usage limit), so automated review is incomplete and this is not approved. Human review is needed; no reviewers were assigned because the only identifiable editor is the PR author and the CODEOWNERS team could not be resolved to usernames.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

…nion removal in changelog

Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
@macroscopeapp

macroscopeapp Bot commented Aug 12, 2026

Copy link
Copy Markdown

Approvability

Verdict: Needs human review

Author does not own any changed files (all owned by wave-av/sdk-owners). Unresolved review comment at Medium severity raises concern that edits to generated SDK source will be overwritten by next automated sync. Additional comments note incomplete cleanup of Dash0 references elsewhere.

No code changes detected at 76aa1e1. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

… removed)

Addresses review thread: the public type surface changed (dash0 removed
from ConsoleSourceResult['source']), so it's called out as breaking under
Unreleased.
@wave-bugbot

wave-bugbot Bot commented Aug 12, 2026

Copy link
Copy Markdown

🌊 WAVE BugBot — 4 finding(s)

🔴 3 · 🟠 1

  • 🔴 P0 sdk-typescript/packages/console/src/console.ts:9 CWE-269Missing role guard on SECURITY DEFINER RPC
    The ConsoleModule class does not check the caller's role before processing requests. This could allow unauthorized access to sensitive data or operations.
  • 🔴 P0 sdk-typescript/packages/console/src/console.ts:9 CWE-269Missing authentication check for RPC
    The ConsoleModule class does not perform any authentication checks on incoming requests. This could allow unauthorized access to sensitive data or operations.
  • 🔴 P0 sdk-typescript/packages/console/src/console.ts:9 CWE-840Potential money-path vulnerability in query method
    The ConsoleModule class does not perform any authorization checks on financial data, which could allow unauthorized access to sensitive revenue or billing inf
  • 🟠 P1 sdk-typescript/packages/console/src/console.ts:9 CWE-476Potential NULL pointer dereference in query method
    The ConsoleModule class does not guard against potential NULL pointer dereferences when accessing properties of the response object.

severity: critical · major · minor · info — local review · $0 inference · wave-dispatch · react 👍/👎 to tune

@yakimoto yakimoto added the auto-approve Opt-in: wave-av-reviewbot may approve this PR when all checks are green label Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-approve Opt-in: wave-av-reviewbot may approve this PR when all checks are green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant