Skip to content

Add capability for cmake to fetch libtorch itself if not found #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kjh-giesbertz wants to merge 6 commits into
base: skala
Choose a base branch
from
Open

Add capability for cmake to fetch libtorch itself if not found #173

kjh-giesbertz wants to merge 6 commits into from

Conversation

@kjh-giesbertz
Copy link

@kjh-giesbertz kjh-giesbertz commented Jan 22, 2026 •
edited
Loading

Currently the user needs to install torch him-/herself to be able to use skala. libtorch can actually be downloaded from the pytorch site, so the PR adds this functionality to cmake.

  • The cpu version is pretty straightforward.
    Tested on:
    • Mac
    • Linux (wsl)
    • Windows
  • The gpu version is more tricky as the download needs to match the particular cuda version. The script is supposed to test whether there is a match and if not, falls back to the cpu version. The versions are quite strict though: 12.6, 12.8 and 13.0.
    • Linux (cuda 12.8)
    • Windows

Klaas Giesbertz and others added 2 commits January 19, 2026 13:31
Initial version for lettign cmake add libtorch automatically. cpu ver…
78895e8 
…sion is probably ok (at leat on my mac it works), but gpu still needs to filter versions correctly.
Include and verify the possible CUDA versions for which libtorch down…
3e2faef 
…loads are available. Still needs to be tested.
@kjh-giesbertz kjh-giesbertz marked this pull request as draft January 22, 2026 09:55
@kjh-giesbertz kjh-giesbertz marked this pull request as ready for review January 22, 2026 09:55
@kjh-giesbertz kjh-giesbertz marked this pull request as draft January 22, 2026 09:55
@kjh-giesbertz kjh-giesbertz marked this pull request as ready for review January 22, 2026 14:31
The Caffe cmake from libtorch uses the old way to include CUDA, so fi…
b0e70e4 
…nd_package(CUDA REQUIRED) needed to included. The CUDA_VERSION_STRING conflicts, so renamed that to CUDA_VERSION_NO_DOT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kjh-giesbertz