Skip to content

fix(term): emit distinct CSI-u sequence for Ctrl+Enter in terminal blocks #3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jason-Shen2 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(term): emit distinct CSI-u sequence for Ctrl+Enter in terminal blocks #3408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9b3c86
fix(term): emit CSI-u sequence for Ctrl+Enter in terminal blocks
Jason-Shen2 Jul 2, 2026
d7dfec9
fix(term): gate Ctrl+Enter CSI-u sequence behind term:ctrlenter confi…
Jason-Shen2 Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/generateschema/main-generateschema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ type WidgetsMetaSchemaHints struct {
TermTransparency *float64 `json:"term:transparency,omitempty"`
TermAllowBracketedPaste *bool `json:"term:allowbracketedpaste,omitempty"`
TermShiftEnterNewline *bool `json:"term:shiftenternewline,omitempty"`
TermCtrlEnter *bool `json:"term:ctrlenter,omitempty"`
TermMacOptionIsMeta *bool `json:"term:macoptionismeta,omitempty"`
TermBellSound *bool `json:"term:bellsound,omitempty"`
TermBellIndicator *bool `json:"term:bellindicator,omitempty"`
Expand Down
10 changes: 10 additions & 0 deletions frontend/app/view/term/term-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,16 @@ export class TermViewModel implements ViewModel {
return false;
}
}
if (keyutil.checkKeyPressed(waveEvent, "Ctrl:Enter")) {
const ctrlEnterAtom = getOverrideConfigAtom(this.blockId, "term:ctrlenter");
const ctrlEnterEnabled = globalStore.get(ctrlEnterAtom) ?? true;
if (ctrlEnterEnabled) {
this.sendDataToController("\x1b[13;5u");
event.preventDefault();
event.stopPropagation();
return false;
}
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

// Check for Ctrl-V paste (platform-dependent)
if (this.shouldHandleCtrlVPaste() && keyutil.checkKeyPressed(waveEvent, "Ctrl:v")) {
Expand Down
2 changes: 2 additions & 0 deletions frontend/types/gotypes.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,6 +1182,7 @@ declare global {
"term:transparency"?: number;
"term:allowbracketedpaste"?: boolean;
"term:shiftenternewline"?: boolean;
"term:ctrlenter"?: boolean;
"term:macoptionismeta"?: boolean;
"term:cursor"?: string;
"term:cursorblink"?: boolean;
Expand Down Expand Up @@ -1417,6 +1418,7 @@ declare global {
"term:transparency"?: number;
"term:allowbracketedpaste"?: boolean;
"term:shiftenternewline"?: boolean;
"term:ctrlenter"?: boolean;
"term:macoptionismeta"?: boolean;
"term:cursor"?: string;
"term:cursorblink"?: boolean;
Expand Down
1 change: 1 addition & 0 deletions pkg/waveobj/metaconsts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ const (
MetaKey_TermTransparency = "term:transparency"
MetaKey_TermAllowBracketedPaste = "term:allowbracketedpaste"
MetaKey_TermShiftEnterNewline = "term:shiftenternewline"
MetaKey_TermCtrlEnter = "term:ctrlenter"
MetaKey_TermMacOptionIsMeta = "term:macoptionismeta"
MetaKey_TermCursor = "term:cursor"
MetaKey_TermCursorBlink = "term:cursorblink"
Expand Down
1 change: 1 addition & 0 deletions pkg/waveobj/wtypemeta.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ type MetaTSType struct {
TermTransparency *float64 `json:"term:transparency,omitempty"` // default 0.5
TermAllowBracketedPaste *bool `json:"term:allowbracketedpaste,omitempty"`
TermShiftEnterNewline *bool `json:"term:shiftenternewline,omitempty"`
TermCtrlEnter *bool `json:"term:ctrlenter,omitempty"`
TermMacOptionIsMeta *bool `json:"term:macoptionismeta,omitempty"`
TermCursor string `json:"term:cursor,omitempty"`
TermCursorBlink *bool `json:"term:cursorblink,omitempty"`
Expand Down
1 change: 1 addition & 0 deletions pkg/wconfig/metaconsts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ const (
ConfigKey_TermTransparency = "term:transparency"
ConfigKey_TermAllowBracketedPaste = "term:allowbracketedpaste"
ConfigKey_TermShiftEnterNewline = "term:shiftenternewline"
ConfigKey_TermCtrlEnter = "term:ctrlenter"
ConfigKey_TermMacOptionIsMeta = "term:macoptionismeta"
ConfigKey_TermCursor = "term:cursor"
ConfigKey_TermCursorBlink = "term:cursorblink"
Expand Down
1 change: 1 addition & 0 deletions pkg/wconfig/settingsconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ type SettingsType struct {
TermTransparency *float64 `json:"term:transparency,omitempty"`
TermAllowBracketedPaste *bool `json:"term:allowbracketedpaste,omitempty"`
TermShiftEnterNewline *bool `json:"term:shiftenternewline,omitempty"`
TermCtrlEnter *bool `json:"term:ctrlenter,omitempty"`
TermMacOptionIsMeta *bool `json:"term:macoptionismeta,omitempty"`
TermCursor string `json:"term:cursor,omitempty"`
TermCursorBlink *bool `json:"term:cursorblink,omitempty"`
Expand Down
3 changes: 3 additions & 0 deletions schema/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@
"term:shiftenternewline": {
"type": "boolean"
},
"term:ctrlenter": {
"type": "boolean"
},
"term:macoptionismeta": {
"type": "boolean"
},
Expand Down
3 changes: 3 additions & 0 deletions schema/widgets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,9 @@
"term:shiftenternewline": {
"type": "boolean"
},
"term:ctrlenter": {
"type": "boolean"
},
"term:macoptionismeta": {
"type": "boolean"
},
Expand Down