fix(webview): respect system color scheme for prefers-color-scheme in web blocks#3413
fix(webview): respect system color scheme for prefers-color-scheme in web blocks#3413Jason-Shen2 wants to merge 1 commit into
Conversation
… web blocks Fixes wavetermdev#3318 by changing nativeTheme.themeSource from dark to system. Wave's own UI remains dark-themed via CSS color-scheme and custom scrollbar styling.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis change modifies a single configuration line in the Electron main process file, updating the native theme source setting from a hardcoded "dark" value to "system", causing the application to follow the operating system's theme preference. Estimated code review effort: 1 (Trivial) | ~2 minutes Changes
Related issues: None specified. Related PRs: None specified. Suggested labels: None Suggested reviewers: None Poem 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #3318
Changes
nativeTheme.themeSourcefrom 'dark' to 'system' so that embedded web content (web blocks) correctly respects the OS color scheme preference. Wave's own UI remains dark-themed via CSScolor-scheme: darkand custom scrollbar styling, so this only affects webview/iframe content.