Conversation
Beginning work on new web ui
The changes to WebUI.cpp are in the Firmware-Updates branch and are dependent on other changes in that branch. In particular, the addition of the HttpContent class.
Moving it /json to after /json/config resolves this
/json/config was hitting /json
I can't get LittleFS to flash OTA.
OTA the file system, then reboot the ESP.
Update github actions and change log
Fix input types not showing values.
Closed
# Conflicts: # CHANGELOG.md # lib/Config/Config.cpp # lib/Config/Config.h # lib/WebUI/WebUI.cpp # lib/WebUI/WebUI.h # src/main.cpp
Collaborator
Author
|
I have reviewed this, and it's good to merge, but I'll let @wayne-love decide/review before merging into master. |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Collaborator
Author
|
Update coming soon from me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to check I've correctly resolved the merge conflicts, but once I have we should merge this into master. I'll check it again tomorrow, as I don't want to break master...