Fix the same chunkId is overwritten after using mini-css-extract-plugin#225
Open
msidolphin wants to merge 1 commit intowaysact:mainfrom
Open
Fix the same chunkId is overwritten after using mini-css-extract-plugin#225msidolphin wants to merge 1 commit intowaysact:mainfrom
msidolphin wants to merge 1 commit intowaysact:mainfrom
Conversation
jscheid
requested changes
Oct 12, 2023
Collaborator
jscheid
left a comment
There was a problem hiding this comment.
Thanks for your contribution. Please could you add a test case that fails without the code changes? Tests still pass after I remove your change from examples/mini-css-extract-plugin/webpack.config.js.
Author
Ok, I'll remove this change and add additional unit tests |
6a872cf to
e9a568a
Compare
|
@jscheid hi, any plan to merge this feature? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
#216
Usage
Since mini-css-extract-plugin does not currently provide some hooks, developers can only inject their own integrity attributes via the insert function, I plan to inject integrity via the beforeTagInsert hook