Skip to content

Prevent ElasticSearchAliasInit jobs overlapping #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
outdooracorn merged 1 commit into from
Feb 16, 2026
+13 −0
Merged

Prevent ElasticSearchAliasInit jobs overlapping #1056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions app/Jobs/ElasticSearchAliasInit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use App\Http\Curl\HttpRequest;
use App\WikiDb;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Queue\Middleware\WithoutOverlapping;
use Illuminate\Support\Facades\Log;

class ElasticSearchAliasInit extends Job {
Copy link
Member Author

@outdooracorn outdooracorn Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also add $tries and $backoff class properties to this job so that any failed jobs are retried after a period of time. https://laravel.com/docs/12.x/queues#dealing-with-failed-jobs

Copy link
Contributor

@tarrow tarrow Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the worst idea. I think perhaps we could also add this with a follow-up if, when we run it, we see any failure. For now I'd leave it be

Expand All @@ -24,6 +25,18 @@ public function __construct(int $wikiId, string $esHost, ?string $sharedPrefix =
$this->sharedPrefix = $sharedPrefix ?? getenv('ELASTICSEARCH_SHARED_INDEX_PREFIX');
}

/**
* Get the middleware the job should pass through.
*
* @return array<int, object>
*/
public function middleware(): array {
return [
// Only allow one job per ES host to run at a time to avoid DoSing the ES cluster with alias updates
new WithoutOverlapping("elasticsearch-alias-init-{$this->esHost}"),
Copy link
Contributor

@tarrow tarrow Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: nice, and good to do it per cluster rather than globally

];
}

public function handle(HttpRequest $request) {
Log::info(__METHOD__ . ": Updating Elasticsearch aliases for $this->wikiId");

Expand Down
Loading