Draft
Conversation
dati18
force-pushed
the
authenticate-middleware-test
branch
from
7a3465a to
ce11fce
Compare
dati18
force-pushed
the
authenticate-middleware-test
branch
from
ce11fce to
e7e399b
Compare
tarrow
reviewed
May 6, 2026
| ->assertJson(['email' => $user->email]); | ||
| } | ||
|
|
||
| public function testAuthenticatesUsingPassportTokenFromAuthorizationHeader(): void { |
Contributor
There was a problem hiding this comment.
This is a nice idea to ensure that our Middleware doesn't break any Authorization Header workflows
Contributor
Author
There was a problem hiding this comment.
yeah I said it in the PR description but haven't done it till now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Authenticate.php did not have a test, so I wrote one for it.
I think we can also test authenticating using Passport token from Authorization Header