Skip to content

Fix DefaultTransition when width is not yet known #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kritarie merged 2 commits into from
Mar 6, 2026
Merged

Fix DefaultTransition when width is not yet known #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a59c510
When determining the y translation distance for the default animation…
Kritarie Mar 2, 2026
4b7f79c
Fix unit test
Kritarie Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion magellan-library/src/main/java/com/wealthfront/magellan/transitions/DefaultTransition.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ public class DefaultTransition : MagellanTransition {
): AnimatorSet {
val sign = direction.sign()
val axis: Property<View, Float> = View.TRANSLATION_X
val toTranslation = sign * to.width
val toTranslation = if (to.width > 0) {
sign * to.width
} else {
sign * (to.parent as View).width
}
val set = AnimatorSet()
if (from != null) {
val fromTranslation = sign * -from.width
Expand Down
5 changes: 5 additions & 0 deletions magellan-library/src/test/java/com/wealthfront/magellan/transitions/DefaultTransitionTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package com.wealthfront.magellan.transitions

import android.os.Looper.getMainLooper
import android.view.View
import android.widget.FrameLayout
import androidx.test.core.app.ApplicationProvider.getApplicationContext
import com.google.common.truth.Truth.assertThat
import com.wealthfront.magellan.Direction
Expand Down Expand Up @@ -47,6 +48,10 @@ class DefaultTransitionTest {
private fun animate(direction: Direction): MagellanTransition {
val from = View(getApplicationContext())
val to = View(getApplicationContext())
FrameLayout(getApplicationContext()).apply {
addView(from)
addView(to)
}
return DefaultTransition().apply {
animate(from, to, direction) {
onAnimationEndCalled = true
Expand Down
Loading