Update README.md with installation instructions#139
Open
mheiber wants to merge 1 commit intoweb-animations:devfrom
Open
Update README.md with installation instructions#139mheiber wants to merge 1 commit intoweb-animations:devfrom
mheiber wants to merge 1 commit intoweb-animations:devfrom
Conversation
Add installation instructions. The README didn't reference npm even though there is an npm package: web-animations#134 had a TODO for adding the installation instructions to the README. Are these installation instructions right? Or is it `require('web-animation-js').polyfill()` instead of just `require('web-animation-js')`? Thank you for your work on this library and the cool demos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add installation instructions. The README didn't reference npm even though there is an npm package: #134 had a TODO for adding the installation instructions to the README.
Are these installation instructions right? Or is it
require('web-animation-js').polyfill()instead of justrequire('web-animation-js')?Thank you for your work on this library and the cool demos.