Assign more Permissions-related keys#2614
Merged
Merged
Conversation
github-actions
Bot
added
the
feature definition
ddbeck
force-pushed
the
more-permissions
branch
from
add057b to
7b12a60
Compare
ddbeck
force-pushed
the
more-permissions
branch
from
7b12a60 to
9ce37eb
Compare
foolip
approved these changes
Feb 11, 2025
foolip
left a comment
foolip
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! If resolving conflicts turns up something interesting, feel free to circle back for more review. Otherwise, please land without further review.
| - api.Magnetometer.x | ||
| - api.Magnetometer.y | ||
| - api.Magnetometer.z | ||
| - api.Permissions.permission_magnetometer |
Collaborator
There was a problem hiding this comment.
This features seems wrong, I've filed #2631.
But no reason to not make this change here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR assigns all but one of the keys remaining from the Permissions API spec to their respective features.
The one key left unassigned is
api.Permissions.permission_accessibility-events. For the history of this key, see mdn/browser-compat-data#25860 for more info on this one key. I've decided to send it to the unspecified web APIs bucket; see #2566