fix: add explicit extensions to web-features#4151
Open
43081j wants to merge 1 commit into
Open
Conversation
Importing `web-features` in a project which uses node16 resolution currently fails since it can't resolve `"./types"`. This means the types we get are basically `Record<string, any>` rather than `Record<string, FeatureData>`. Given that this package requires a node-like runtime (it imports `node:fs`), I think it makes sense to set the `module` to `node18` and the `moduleResolution` to `node16`. This should basically enforce things like file extensions, respecting export maps, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing
web-featuresin a project which uses node16 resolutioncurrently fails since it can't resolve
"./types". This means the typeswe get are basically
Record<string, any>rather thanRecord<string, FeatureData>.Given that this package requires a node-like runtime (it imports
node:fs),I think it makes sense to set the
moduletonode18and themoduleResolutiontonode16.This should basically enforce things like file extensions, respecting export
maps, etc.